-
Notifications
You must be signed in to change notification settings - Fork 81
Bump protobuf-java to 3.33.1 #2483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance update, specifically bumping the version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the protobuf-java version from 3.25.8 to 3.33.1. This is a significant version bump, and I've raised a concern about potential compatibility issues with the existing grpc.version, which is not being updated. It's generally recommended to update these dependencies together to avoid runtime issues. Additionally, the release links in the pull request description appear to be broken.
|
|
||
| <properties> | ||
| <protobuf.version>3.25.8</protobuf.version> | ||
| <protobuf.version>3.33.1</protobuf.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping protobuf.version to 3.33.1 without also updating grpc.version (currently 1.76.0) can introduce binary incompatibilities at runtime. gRPC libraries have a strong dependency on Protobuf, and a significant version skew between them is risky. It is highly recommended to update grpc.version to a version that is compatible with protobuf-java:3.33.1 to ensure stability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is grpc version 1.77.0 OK?
https://github.com/protocolbuffers/protobuf/releases/tag/v29.5 https://github.com/protocolbuffers/protobuf/releases/tag/v31.1 https://github.com/protocolbuffers/protobuf/releases/tag/v32.0 https://github.com/protocolbuffers/protobuf/releases/tag/v32.1 https://github.com/protocolbuffers/protobuf/releases/tag/v33.0 https://github.com/protocolbuffers/protobuf/releases/tag/v33.1 Signed-off-by: Ivan Hrasko <[email protected]>
3776785 to
df21d2e
Compare
https://github.com/protocolbuffers/protobuf/releases/tag/v29.5 https://github.com/protocolbuffers/protobuf/releases/tag/v31.1 https://github.com/protocolbuffers/protobuf/releases/tag/v32.0 https://github.com/protocolbuffers/protobuf/releases/tag/v32.1 https://github.com/protocolbuffers/protobuf/releases/tag/v33.0 https://github.com/protocolbuffers/protobuf/releases/tag/v33.1