Update lighty-bgp example postman collection

[PeterSuna]

• Fix the "router-id" to localhost, based on the request URL where lighty is running.
• Remove unnecessary GET request body.
• Fix "Connect peer" to POST type.

[gemini-code-assist]

Summary of Changes

Hello @PeterSuna, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the lighty-bgp example Postman collection to enhance its accuracy and ease of use. The changes primarily involve standardizing the target host to localhost, correcting HTTP methods for BGP peer connections, and removing redundant request bodies. A new feature has also been introduced to simplify the process of connecting multiple BGP peers, making the example more robust and functional for local development and testing.

Highlights

• Router ID Update: The BGP router-id in the configuration has been updated to '127.0.0.1' to align with localhost operations.
• Postman Variable Removal: The 'lighty-host' Postman variable has been removed, and all request URLs are now hardcoded to '127.0.0.1:8888' for direct local execution.
• Request Body Cleanup: Unnecessary raw request bodies have been removed from several GET requests, streamlining the collection.
• Connect Peer Method Correction: The 'Connect peer' request method has been corrected from GET to POST, which is the appropriate HTTP verb for this operation.
• New Multiple Peer Connection Request: A new 'Connect MULTIPLE peer' PUT request has been added, allowing for the configuration of several BGP neighbors (127.0.0.2 through 127.0.0.6) simultaneously.
• BGP Peer Group Remote Port Adjustment: The remote-port for the 'external-neighbor' peer group has been changed from '179' to '17900'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request updates the Lighty-BGP example Postman collection. Key changes include fixing the router-id to localhost, removing unnecessary GET request bodies, and correcting the 'Connect peer' request to use the POST method. While these changes align with the stated goals, the removal of the lighty-host variable and subsequent hardcoding of 127.0.0.1:8888 throughout the collection reduces its flexibility and reusability for different environments. Additionally, the removal of extensive <afi-safis> configurations in some requests simplifies the examples but might limit their comprehensiveness.

[ihrasko]

I would stay with parameter {lighty-host} - because my lighty is not running on localhost when I invoke the requests :)

[ihrasko]

Why do we change topology id/name?

[ihrasko]

Suddenly we have lost an half of body - can you provide the reason for it?

[ihrasko]

Document that we have a new request in collection - commit message or new commit.