chore(android,ios): remove unnecessary Firebase preferences (#58)

* fix: properly set `FirebaseAutomaticScreenReportingEnabled` key

References: https://outsystemsrd.atlassian.net/browse/RMET-4915

* fix: remove FirebaseAutomaticScreenReportingEnabled altogether

Context: By default the preference is already true in iOS, so no need to explicitly set it.

References: https://outsystemsrd.atlassian.net/browse/RMET-4915

* chore: remove unnecessary preference from Android

Context: It is also true by default, so we don't need to specifically set it.

* chore: remove unnecessary preferences from Android and iOS for Capacitor builds

Context: These are already true by default, so no need to explicitly set them.

* chore: update PR template

* chore(release): raise to version 5.0.0-OS20

Author: alexgerardojacinto

CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 The changes documented here do not include those from the original repository.
 
+## 5.0.0-OS20
+
+### Chores
+- [Android,iOS] remove unnecessary Firebase preferences (https://outsystemsrd.atlassian.net/browse/RMET-4915).
+
 ## 5.0.0-OS19
 
 ### Fixes

PULL_REQUEST_TEMPLATE.md

@@ -25,7 +25,6 @@
 
 ## Checklist
 <!--- Go over all the following items and put an `x` in all the boxes that apply -->
-- [ ] Pull request title follows the format `RNMT-XXXX <title>`
 - [ ] Code follows code style of this project
 - [ ] CHANGELOG.md file is correctly updated
 - [ ] Changes require an update to the documentation

build-actions/setAnalyticsConfigurations.yaml

@@ -11,10 +11,6 @@ variables:
 platforms:
   android:
     manifest:          
-      - file: AndroidManifest.xml
-        target: manifest/application
-        inject: |
-          <meta-data android:name="google_analytics_automatic_screen_reporting_enabled" android:value="true"/>
       - file: AndroidManifest.xml
         target: manifest/application
         inject: |
@@ -23,7 +19,6 @@ platforms:
     plist:
       - replace: true
         entries:
-          - FirebaseAutomaticScreenReportingEnabled: true
           - FIREBASE_ANALYTICS_COLLECTION_ENABLED: $ANALYTICS_COLLECTION_ENABLED
 
       - replace: true

hooks/ios/iOSCopyPreferences.js

@@ -12,6 +12,8 @@ module.exports = function (context) {
     let infoPlistPath = path.join(projectRoot, 'platforms/ios/' + appName + '/'+ appName +'-info.plist');
     let obj = plist.parse(fs.readFileSync(infoPlistPath, 'utf8'));
 
+
+    // set NSUserTrackingUsageDescription if EnableAppTrackingTransparencyPrompt is true
     let enableAppTracking = configParser.getPlatformPreference("EnableAppTrackingTransparencyPrompt", "ios");
     if(enableAppTracking == "true" || enableAppTracking == ""){
         let userTrackingDescription = configParser.getPlatformPreference("USER_TRACKING_DESCRIPTION_IOS", "ios");
@@ -20,13 +22,13 @@ module.exports = function (context) {
         }
     }
     else if(enableAppTracking == "false"){
-        delete obj['NSUserTrackingUsageDescription'];        
+        delete obj['NSUserTrackingUsageDescription'];
     }
 
     let collectionEnabled = configParser.getGlobalPreference("ANALYTICS_COLLECTION_ENABLED");
     if (collectionEnabled.toLowerCase() == 'false') {
         obj['FIREBASE_ANALYTICS_COLLECTION_ENABLED'] = false;
-    } 
+    }
 
     fs.writeFileSync(infoPlistPath, plist.build(obj));
 };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-firebase-analytics",
-  "version": "5.0.0-OS19",
+  "version": "5.0.0-OS20",
   "description": "Cordova plugin for Firebase Analytics",
   "cordova": {
     "id": "cordova-plugin-firebase-analytics",

plugin.xml

@@ -1,7 +1,7 @@
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
 xmlns:android="http://schemas.android.com/apk/res/android"
            id="cordova-plugin-firebase-analytics"
-      version="5.0.0-OS19">
+      version="5.0.0-OS20">
 
     <name>FirebaseAnalyticsPlugin</name>
     <description>Cordova plugin for Firebase Analytics</description>
@@ -20,7 +20,6 @@ xmlns:android="http://schemas.android.com/apk/res/android"
         <engine name="cordova-ios" version=">=5.1.1"/>
     </engines>
 
-    <preference name="AUTOMATIC_SCREEN_REPORTING_ENABLED" default="true" />
     <preference name="USER_TRACKING_DESCRIPTION_IOS" default="$(PRODUCT_NAME) needs your attention." />
 
     <platform name="ios">
@@ -41,9 +40,6 @@ xmlns:android="http://schemas.android.com/apk/res/android"
             use a bit hacky method to set boolean value as a string:
             https://developer.apple.com/documentation/foundation/nsstring/1409420-boolvalue?preferredLanguage=occ
         -->
-        <config-file target="*-Info.plist" parent="FirebaseAutomaticScreenReportingEnabled">
-            <string>$AUTOMATIC_SCREEN_REPORTING_ENABLED</string>
-        </config-file>
         <config-file target="*-Info.plist" parent="NSUserTrackingUsageDescription">
             <string>$USER_TRACKING_DESCRIPTION_IOS</string>
         </config-file>
@@ -95,10 +91,6 @@ xmlns:android="http://schemas.android.com/apk/res/android"
             <uses-permission android:name="android.permission.INTERNET" />
         </edit-config>
 
-        <edit-config target="AndroidManifest.xml" parent="/manifest/application">
-            <meta-data android:name="google_analytics_automatic_screen_reporting_enabled" android:value="$AUTOMATIC_SCREEN_REPORTING_ENABLED" />
-        </edit-config>
-
         <framework src="build.gradle" custom="true" type="gradleReference" />
 
         <source-file src="src/android/com/outsystems/firebase/analytics/FirebaseAnalyticsPlugin.java" target-dir="src/com/outsystems/plugins/firebase/analytics/" />