Skip to content

Commit 6ccb243

Browse files
authored
feat(app, api-client): add optional runTimeParameterValues when cloning run (#14787)
closes AUTH-257
1 parent 2397044 commit 6ccb243

File tree

6 files changed

+16
-8
lines changed

6 files changed

+16
-8
lines changed

api-client/src/runs/createRun.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ import type { HostConfig } from '../types'
55
import type {
66
Run,
77
LabwareOffsetCreateData,
8-
RuntimeParameterCreateData,
8+
RunTimeParameterCreateData,
99
} from './types'
1010

1111
export interface CreateRunData {
1212
protocolId?: string
1313
labwareOffsets?: LabwareOffsetCreateData[]
14-
runTimeParameterValues?: RuntimeParameterCreateData
14+
runTimeParameterValues?: RunTimeParameterCreateData
1515
}
1616

1717
export function createRun(

api-client/src/runs/types.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export interface LegacyGoodRunData {
4747
modules: LoadedModule[]
4848
protocolId?: string
4949
labwareOffsets?: LabwareOffset[]
50+
runTimeParameterValues?: RunTimeParameterCreateData
5051
}
5152

5253
export interface KnownGoodRunData extends LegacyGoodRunData {
@@ -125,7 +126,7 @@ export interface LabwareOffsetCreateData {
125126
vector: VectorOffset
126127
}
127128

128-
export interface RuntimeParameterCreateData {
129+
export interface RunTimeParameterCreateData {
129130
[key: string]: string | boolean | number
130131
}
131132

app/src/organisms/ChooseProtocolSlideout/index.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ import { useCreateRunFromProtocol } from '../ChooseRobotToRunProtocolSlideout/us
4747
import { ApplyHistoricOffsets } from '../ApplyHistoricOffsets'
4848
import { useOffsetCandidatesForAnalysis } from '../ApplyHistoricOffsets/hooks/useOffsetCandidatesForAnalysis'
4949
import { getAnalysisStatus } from '../ProtocolsLanding/utils'
50+
import type { RunTimeParameterCreateData } from '@opentrons/api-client'
5051
import type { RunTimeParameter } from '@opentrons/shared-data'
5152
import type { Robot } from '../../redux/discovery/types'
5253
import type { StoredProtocolData } from '../../redux/protocol-storage'
@@ -161,7 +162,7 @@ export function ChooseProtocolSlideoutComponent(
161162
definitionUri,
162163
}))
163164
: [],
164-
runTimeParametersOverrides.reduce(
165+
runTimeParametersOverrides.reduce<RunTimeParameterCreateData>(
165166
(acc, param) =>
166167
param.value !== param.default
167168
? { ...acc, [param.variableName]: param.value }

app/src/organisms/ChooseRobotToRunProtocolSlideout/useCreateRunFromProtocol.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import type {
1414
HostConfig,
1515
LabwareOffsetCreateData,
1616
Protocol,
17-
RuntimeParameterCreateData,
17+
RunTimeParameterCreateData,
1818
} from '@opentrons/api-client'
1919
import type { UseCreateRunMutationOptions } from '@opentrons/react-api-client/src/runs/useCreateRunMutation'
2020
import type { CreateProtocolVariables } from '@opentrons/react-api-client/src/protocols/useCreateProtocolMutation'
@@ -37,7 +37,7 @@ export function useCreateRunFromProtocol(
3737
options: UseCreateRunMutationOptions,
3838
hostOverride?: HostConfig | null,
3939
labwareOffsets?: LabwareOffsetCreateData[],
40-
runTimeParameterValues?: RuntimeParameterCreateData
40+
runTimeParameterValues?: RunTimeParameterCreateData
4141
): UseCreateRun {
4242
const contextHost = useHost()
4343
const host =

app/src/organisms/ProtocolUpload/hooks/__tests__/useCloneRun.test.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ describe('useCloneRun hook', () => {
3030
id: RUN_ID,
3131
protocolId: 'protocolId',
3232
labwareOffsets: 'someOffset',
33+
runTimeParameterValues: 'someRtp',
3334
},
3435
},
3536
} as any)
@@ -60,6 +61,7 @@ describe('useCloneRun hook', () => {
6061
expect(mockCreateRun).toHaveBeenCalledWith({
6162
protocolId: 'protocolId',
6263
labwareOffsets: 'someOffset',
64+
runTimeParameterValues: 'someRtp',
6365
})
6466
})
6567
})

app/src/organisms/ProtocolUpload/hooks/useCloneRun.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,12 @@ export function useCloneRun(
3030
})
3131
const cloneRun = (): void => {
3232
if (runRecord != null) {
33-
const { protocolId, labwareOffsets } = runRecord.data
34-
createRun({ protocolId, labwareOffsets })
33+
const {
34+
protocolId,
35+
labwareOffsets,
36+
runTimeParameterValues,
37+
} = runRecord.data
38+
createRun({ protocolId, labwareOffsets, runTimeParameterValues })
3539
} else {
3640
console.info('failed to clone run record, source run record not found')
3741
}

0 commit comments

Comments
 (0)