Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for escaping JSON to Strings lib #5251

Open
arr00 opened this issue Oct 11, 2024 · 4 comments · May be fixed by #5508
Open

Add support for escaping JSON to Strings lib #5251

arr00 opened this issue Oct 11, 2024 · 4 comments · May be fixed by #5508
Labels
good first issue Low hanging fruit for new contributors to get involved!
Milestone
5.4

Comments

@arr00
Copy link
Contributor

arr00 commented Oct 11, 2024

🧐 Motivation
Some existing solidity libraries have functions that allow escaping JSON strings--this is crucial for NFT metadata stored on-chain with user input to ensure there can't be injection attacks. We should consider adding a similar feature to the strings library.
@arr00 arr00 added this to the 5.3 milestone Oct 11, 2024
@hrik2001
Copy link
Contributor

hrik2001 commented Dec 7, 2024

Hey @arr00, hope you are doing well, I think I will be able to take up this ticket. We can spec it out the PR here and then I can start working

@guy-do-or-die
Copy link

dear @arr00 can you advise one? i tried out some uniswap's helpers but it didn't serve me well enough unfortunatelly. thx!

@Amxx Amxx added the good first issue Low hanging fruit for new contributors to get involved! label Feb 12, 2025
@DarkLord017
Copy link

Hey @Amxx , would like to work on this issue

@Amxx
Copy link
Collaborator

Amxx commented Feb 13, 2025

Sure @DarkLord017

Fell free to submit an PR.

@Amxx Amxx modified the milestones: 5.3, 5.4 Feb 13, 2025
DarkLord017 added a commit to DarkLord017/openzeppelin-contracts that referenced this issue Feb 14, 2025
@DarkLord017
ref: added functionality to escapeJSONstrings (ref: OpenZeppelin#5251)
7eb3f6f
@DarkLord017 DarkLord017 linked a pull request Feb 14, 2025 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved!
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

ref: added functionality to escapeJSONstrings (ref: #5251) DarkLord017/openzeppelin-contracts
6 participants
@Amxx @guy-do-or-die @hrik2001 @arr00 @DarkLord017 and others