fix(notes): cap live speaker count to expected count in note recordings (#967)

* fix(notes): cap live speaker count to expected count in note recordings

Normal note recordings default to one other speaker, but the live
transcript's per-segment 'Speaker N' labels climbed to 2, 3, 4, 5... as
recording continued, because the expected-speaker cap was not applied
consistently.

Renderer (meetingRecordingStore.ts): placeholder speaker ids were minted
without respecting the cap the backend enforces (expectedCount - 1):
- The system partial path minted a fresh speaker on every partial when
  the partial id was null. Since the id is cleared after every final,
  each utterance produced a new speaker, bypassing carry-forward reuse.
- assignProvisionalSpeaker minted unbounded on any gap > 8s.
Add mintPlaceholderSpeakerId() which clamps the index to expectedCount-1
and reuse the recent system speaker in the partial path before minting.

Backend (ipcHandlers.js): meeting-set-session-speaker-config set the
live identifier cap to expectedCount instead of expectedCount-1, so
changing the speaker stepper mid-recording allowed one extra cluster.
Cap at expectedCount-1 to match resolveSessionMaxSpeakers().

Cleanup (diarization.js): remove the unreachable orphan-speaker fallback
in mergeWithTranscript. The nearest-match loop always assigns a real
speaker (diarization output is parsed to speaker_N via regex, so every
cluster has a truthy id), making the fallback dead code that would also
mint past the cap if ever reached.

* fix(window): always follow cursor to active monitor on dictation

The recorder panel only repositioned to the cursor's display when
transitioning from hidden to visible. With the persistent floating
icon (default), the panel is always visible, so it never followed
the cursor across monitors. Always reposition on show — the method
already no-ops when the panel is already on the right display.

Author: gabrielste1n

src/helpers/diarization.js

@@ -8,7 +8,7 @@ const { resolveBinaryPath, gracefulStopProcess } = require("../utils/serverUtils
 const { getModelsDirForService } = require("./modelDirUtils");
 const { convertToWav } = require("./ffmpegUtils");
 const { getSafeTempDir } = require("./safeTempDir");
-const { applyProvisionalSpeaker, applyConfirmedSpeaker } = require("./speakerAssignmentPolicy");
+const { applyConfirmedSpeaker } = require("./speakerAssignmentPolicy");
 const sidecarPidFile = require("./sidecarPidFile");
 const {
   transcriptsOverlap,
@@ -459,8 +459,6 @@ class DiarizationManager {
       return null;
     };
 
-    let fallbackSpeakerIndex = speakerSet.size;
-
     return deduped.map((seg, index) => {
       const enriched = { ...seg };
 
@@ -505,12 +503,6 @@ class DiarizationManager {
             speaker: speakerMap.get(bestSpeaker) || bestSpeaker,
             speakerIsPlaceholder: false,
           });
-        } else if (!enriched.speaker) {
-          applyProvisionalSpeaker(enriched, {
-            speaker: `speaker_${fallbackSpeakerIndex}`,
-            speakerIsPlaceholder: true,
-          });
-          fallbackSpeakerIndex += 1;
         }
       }
 

src/helpers/ipcHandlers.js

@@ -7648,7 +7648,9 @@ class IPCHandlers {
         );
         this.activeMeetingSpeakerConfig = { enabled, expectedCount };
         liveSpeakerIdentifier.setEnabled(enabled);
-        liveSpeakerIdentifier.setMaxSpeakers(expectedCount);
+        // Live identification only labels other speakers (the mic track is "you"),
+        // so cap at expectedCount - 1 to match resolveSessionMaxSpeakers().
+        liveSpeakerIdentifier.setMaxSpeakers(Math.max(1, expectedCount - 1));
         return { success: true };
       } catch (error) {
         return { success: false, error: error.message };

src/helpers/windowManager.js

@@ -1021,11 +1021,7 @@ class WindowManager {
   showDictationPanel(options = {}) {
     const { focus = false } = options;
     if (this.mainWindow && !this.mainWindow.isDestroyed()) {
-      const wasHidden = !this.mainWindow.isVisible() || this.mainWindow.isMinimized();
-
-      if (wasHidden) {
-        this._repositionToCursorDisplay();
-      }
+      this._repositionToCursorDisplay();
 
       if (this.mainWindow.isMinimized()) {
         this.mainWindow.restore();

src/stores/meetingRecordingStore.ts

@@ -537,6 +537,16 @@ function reserveSpeakerIndex(speakerId?: string) {
   nextPlaceholderSpeakerIndex = Math.max(nextPlaceholderSpeakerIndex, idx + 1);
 }
 
+// Other-speaker cap is expectedCount - 1 (the mic track is "you"); mirrors the
+// backend cap so live labels can't climb past the count the user expects.
+function mintPlaceholderSpeakerId(): string {
+  const expected = useMeetingRecordingStore.getState().sessionExpectedCount;
+  const cap = Math.max(1, expected - 1);
+  const index = Math.min(nextPlaceholderSpeakerIndex, cap - 1);
+  nextPlaceholderSpeakerIndex = Math.max(nextPlaceholderSpeakerIndex, index + 1);
+  return `speaker_${index}`;
+}
+
 function assignProvisionalSpeaker(segment: TranscriptSegment): TranscriptSegment {
   if (segment.source !== "system" || segment.speaker) return segment;
 
@@ -584,8 +594,7 @@ function assignProvisionalSpeaker(segment: TranscriptSegment): TranscriptSegment
     });
   }
 
-  const speakerId = `speaker_${nextPlaceholderSpeakerIndex}`;
-  nextPlaceholderSpeakerIndex += 1;
+  const speakerId = mintPlaceholderSpeakerId();
 
   return normalizeTranscriptSegment({
     ...segment,
@@ -888,9 +897,13 @@ export async function startRecording(args: StartRecordingArgs): Promise<void> {
           } else {
             useMeetingRecordingStore.setState({ systemPartial: data.text });
             if (!systemPartialSpeakerIdValue) {
-              const speakerId = `speaker_${nextPlaceholderSpeakerIndex}`;
-              nextPlaceholderSpeakerIndex += 1;
-              setSystemPartialSpeakerIdentity(speakerId, null);
+              // Reuse the recent system speaker before minting — the partial id is
+              // cleared after every final, so always minting spawned one per utterance.
+              const carried = getRecentSystemSpeaker(Date.now());
+              setSystemPartialSpeakerIdentity(
+                carried?.speakerId ?? mintPlaceholderSpeakerId(),
+                carried?.speakerName ?? null
+              );
             }
           }
           return;