Skip to content

add_critical_attrib_v2() overwrites standard, in-place x509-types/$file #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TinCanTech opened this issue May 28, 2025 · 0 comments · Fixed by #1333
Closed

add_critical_attrib_v2() overwrites standard, in-place x509-types/$file #1336

TinCanTech opened this issue May 28, 2025 · 0 comments · Fixed by #1333
Assignees
@TinCanTech
Labels
BUG
Milestone
v3.2.3

Comments

@TinCanTech
Copy link
Collaborator

TinCanTech commented May 28, 2025 •
edited
Loading

In function add_critical_attrib_v2():

   # Use the new tmp-file:$crit_tmp with critical attribute
   mv -f "$crit_tmp" "$2" || return 1

This moves the $crit_tmp file from the temp-session to the live PKI, overwriting the in-place x509-types/$file.
@TinCanTech TinCanTech linked a pull request May 28, 2025 that will close this issue
add_critical_attrib(): export temp-file name as input file #1333
Merged
@TinCanTech TinCanTech added the BUG label May 28, 2025
@TinCanTech TinCanTech added this to the v3.2.3 milestone May 28, 2025
@TinCanTech TinCanTech changed the title add_critical_attrib_v2() overwrites standard, in-place x509-type/file add_critical_attrib_v2() overwrites standard, in-place x509-types/file May 28, 2025
@TinCanTech TinCanTech changed the title add_critical_attrib_v2() overwrites standard, in-place x509-types/file add_critical_attrib_v2() overwrites standard, in-place x509-types/$file May 28, 2025
@TinCanTech TinCanTech self-assigned this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TinCanTech TinCanTech

Labels
BUG
Projects
None yet
Milestone
v3.2.3
Development

Successfully merging a pull request may close this issue.

add_critical_attrib(): export temp-file name as input file TinCanTech/easy-rsa
1 participant
@TinCanTech