Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consider messages with @<otabot's name> and '!' as commands #157

Open
Grazfather opened this issue Oct 25, 2018 · 2 comments
Open

Don't consider messages with @<otabot's name> and '!' as commands #157

Grazfather opened this issue Oct 25, 2018 · 2 comments

Comments

@Grazfather
Copy link
Contributor

slack_-_opentoall
@crclark96 crclark96 mentioned this issue Feb 9, 2019
Closed
@Kileak
Copy link
Collaborator

Kileak commented Feb 15, 2019

Don't really see the issue here, since the bot is working as expected, interpreting the exclamation mark as a command.

The referenced "fix" for this will also only work if the name is directly followed by the exclamation mark,doing

sup @Bishop what's up?!

will for example still result in Unknown handler or command : what's up?!

@Grazfather
Copy link
Contributor Author

Do we want the bot to respond to ! that aren't at the start of the string just because the name was mentioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Grazfather @Kileak