[NFC] Remove OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS flag (#415)

Author: Kyle-Ye

Package.swift

@@ -59,7 +59,6 @@ var sharedSwiftSettings: [SwiftSetting] = [
     .enableUpcomingFeature("InternalImportsByDefault"),
     .enableUpcomingFeature("InferSendableFromCaptures"),
     .unsafeFlags(["-Wwarning", "DeprecatedDeclaration"]), // We want to use deprecated APIs in test targets
-    .define("OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS"),
     // FIXME: -unavailable-decl-optimization=stub is not working somehow (eg. Color.vibrancy). Dig into this later
     .unsafeFlags(["-unavailable-decl-optimization=stub"]),
     .swiftLanguageMode(.v5),

Sources/OpenSwiftUI/View/Control/Slider/Slider.swift

@@ -130,9 +130,7 @@ extension Slider {
     /// The slider calls `onEditingChanged` when editing begins and ends. For
     /// example, on iOS, editing begins when the user starts to drag the thumb
     /// along the slider's track.
-    #if !OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
     @_alwaysEmitIntoClient
-    #endif
     public init<V>(
         value: Binding<V>,
         in bounds: ClosedRange<V> = 0 ... 1,
@@ -141,18 +139,6 @@ extension Slider {
         @ViewBuilder maximumValueLabel: () -> ValueLabel,
         onEditingChanged: @escaping (Bool) -> Void = { _ in }
     ) where V: BinaryFloatingPoint, V.Stride: BinaryFloatingPoint {
-        #if OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
-        self.init(
-            value: value,
-            in: bounds,
-            step: nil,
-            onEditingChanged: onEditingChanged,
-            minimumValueLabel: minimumValueLabel(),
-            maximumValueLabel: maximumValueLabel(),
-            customMinMaxValueLabels: true,
-            label: label()
-        )
-        #else
         self.init(
             value: value,
             in: bounds,
@@ -161,7 +147,6 @@ extension Slider {
             maximumValueLabel: maximumValueLabel(),
             label: label
         )
-        #endif
     }
 
     /// Creates a slider to select a value from a given range, subject to a
@@ -185,9 +170,7 @@ extension Slider {
     /// The slider calls `onEditingChanged` when editing begins and ends. For
     /// example, on iOS, editing begins when the user starts to drag the thumb
     /// along the slider's track.
-    #if !OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
     @_alwaysEmitIntoClient
-    #endif
     public init<V>(
         value: Binding<V>,
         in bounds: ClosedRange<V>,
@@ -197,18 +180,6 @@ extension Slider {
         @ViewBuilder maximumValueLabel: () -> ValueLabel,
         onEditingChanged: @escaping (Bool) -> Void = { _ in }
     ) where V: BinaryFloatingPoint, V.Stride: BinaryFloatingPoint {
-        #if OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
-        self.init(
-            value: value,
-            in: bounds,
-            step: step,
-            onEditingChanged: onEditingChanged,
-            minimumValueLabel: minimumValueLabel(),
-            maximumValueLabel: maximumValueLabel(),
-            customMinMaxValueLabels: true,
-            label: label()
-        )
-        #else
         self.init(
             value: value,
             in: bounds,
@@ -218,7 +189,6 @@ extension Slider {
             maximumValueLabel: maximumValueLabel(),
             label: label
         )
-        #endif
     }
 }
 
@@ -242,34 +212,19 @@ extension Slider where ValueLabel == EmptyView {
     /// The slider calls `onEditingChanged` when editing begins and ends. For
     /// example, on iOS, editing begins when the user starts to drag the thumb
     /// along the slider's track.
-    #if !OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
     @_alwaysEmitIntoClient
-    #endif
     public init<V>(
         value: Binding<V>,
         in bounds: ClosedRange<V> = 0 ... 1,
         @ViewBuilder label: () -> Label,
         onEditingChanged: @escaping (Bool) -> Void = { _ in }
     ) where V: BinaryFloatingPoint, V.Stride: BinaryFloatingPoint {
-        #if OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
-        self.init(
-            value: value,
-            in: bounds,
-            step: nil,
-            onEditingChanged: onEditingChanged,
-            minimumValueLabel: EmptyView(),
-            maximumValueLabel: EmptyView(),
-            customMinMaxValueLabels: false,
-            label: label()
-        )
-        #else
         self.init(
             value: value,
             in: bounds,
             onEditingChanged: onEditingChanged,
             label: label
         )
-        #endif
     }
 
     /// Creates a slider to select a value from a given range, subject to a
@@ -291,36 +246,21 @@ extension Slider where ValueLabel == EmptyView {
     /// The slider calls `onEditingChanged` when editing begins and ends. For
     /// example, on iOS, editing begins when the user starts to drag the thumb
     /// along the slider's track.
-    #if !OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
     @_alwaysEmitIntoClient
-    #endif
     public init<V>(
         value: Binding<V>,
         in bounds: ClosedRange<V>,
         step: V.Stride = 1,
         @ViewBuilder label: () -> Label,
         onEditingChanged: @escaping (Bool) -> Void = { _ in }
     ) where V: BinaryFloatingPoint, V.Stride: BinaryFloatingPoint {
-        #if OPENSWIFTUI_SUPPRESS_DEPRECATED_WARNINGS
-        self.init(
-            value: value,
-            in: bounds,
-            step: step,
-            onEditingChanged: onEditingChanged,
-            minimumValueLabel: EmptyView(),
-            maximumValueLabel: EmptyView(),
-            customMinMaxValueLabels: false,
-            label: label()
-        )
-        #else
         self.init(
             value: value,
             in: bounds,
             step: step,
             onEditingChanged: onEditingChanged,
             label: label
         )
-        #endif
     }
 }