Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle clicking on titles in the library should open in new tab #12

Closed
dakrk opened this issue Feb 13, 2024 · 3 comments · Fixed by #13
Closed

Middle clicking on titles in the library should open in new tab #12

dakrk opened this issue Feb 13, 2024 · 3 comments · Fixed by #13
Labels
bug Something isn't working confirmed help wanted Extra attention is needed

Comments

@dakrk
Copy link
Contributor

dakrk commented Feb 13, 2024

For links and buttons that send you to other pages, you'd usually expect to be able to middle click them to open them in a new tab. However, currently middle clicking them instead scrolls the page as it would if you middle clicked any non interactable part of the page, causing trying to look at multiple apps more of a pain.
(Infact, I think the title grid should be revamped as a whole, it doesn't look as pretty as the rest of the page)

@dakrk
Copy link
Contributor Author

dakrk commented Feb 13, 2024

(oops i pressed enter early)

@Artuto Artuto added bug Something isn't working help wanted Extra attention is needed confirmed labels Feb 13, 2024
@Artuto
Copy link
Member

Artuto commented Feb 13, 2024

I believe this is because it is not a real link:

https://github.com/OpenShopChannel/Website/blob/master/templates/pages/newlibrary.html#L112-L113

Don't know what could be done there...

@dakrk
Copy link
Contributor Author

dakrk commented Feb 13, 2024

Yeah, I noticed that. Ideally it should just be an anchor instead and the href is set to the relevant URL (but I've never actually touched this so I don't know the best approach for that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants