Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation link] Home link in active state when viewing organisations adopting standard #168

Closed
UsmanAfzal opened this issue Jun 23, 2021 · 8 comments · Fixed by #216
Closed

Comments

@UsmanAfzal
Copy link

URL: https://openreferraluk.org/standard-community

Steps to reproduce (keep an eye on the active navigation link): click "community" > "organisations adopting the standard"

@kingdomlevel
Copy link
Contributor

The fix for this is in 2 parts:

  • Update the frontend codebase to change all occurrences of a link to /standard-community to /community/standard-community
    • in App.js
    • in compontents/home/Who/index.js
  • Update the content in the CMS to update any occurrences of /standard-community to /community/standard-community
    • at least: in main menu
    • in footer

@UsmanAfzal
Copy link
Author

@yemijaiyeola @adamgparsons This issue is still occurring.

@UsmanAfzal
Copy link
Author

@matt-porism Could you mark this as complete when the CMS updates have been made please. For someone reason we are unable to assign to you.

@matt-porism
Copy link
Contributor

matt-porism commented Aug 10, 2021

Couldn't see a change in either of the branches that I'm aware of. I've changed the route from /standard-community to /community/standard-community, added a redirect and updated the links I've found in strapi. The "Community" link is now active when viewing this page.

@UsmanAfzal If you are happy, I don't have permission to complete this.

@UsmanAfzal UsmanAfzal self-assigned this Aug 11, 2021
@UsmanAfzal
Copy link
Author

Thanks @matt-porism checked and approved.

@yemijaiyeola
Copy link
Contributor

@matt-porism, sure this finds you well. The front-end changes (related this) have now been pushed to main. Please pull for live site update at your convenience. Many thanks.

@matt-porism
Copy link
Contributor

matt-porism commented Aug 12, 2021 via email

@yemijaiyeola
Copy link
Contributor

yemijaiyeola commented Aug 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment