create dot for collapsed node in trainrunSectionViewObject #669
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Greiner <[email protected]>
emersion
reviewed
Dec 5, 2025
src/app/view/editor-main-view/data-views/trainrunSectionViewObject.ts
Outdated
Show resolved
Hide resolved
emersion
reviewed
Dec 5, 2025
src/app/view/editor-main-view/data-views/trainrunsections.view.ts
Outdated
Show resolved
Hide resolved
Member
|
I wonder if we really need this PR given #661 is almost the same code. Maybe adding a method to get the number of intermediate nodes is worthwhile, but otherwise the code seems pretty similar. Oh, I just realized we don't want to count non-stop intermediate nodes, even if they're collapsed? In other words, we only want to draw a small disc for stops? |
Contributor
Author
|
These changes can be added to #661 of course. We want to draw a dot (small circle) for each intermediate stop collasped node. Intermediate non-stop nodes are not shown (= "ghost"). |
Member
|
This PR uses
|
louisgreiner
commented
Dec 9, 2025
|
|
||
| getCollapsedIntermediateStopCount(): number { | ||
| // Count collapsed source nodes from all trainrun sections except the first one | ||
| return this.trainrunSections.length - 1; |
Contributor
Author
There was a problem hiding this comment.
Should check if the nodes are actual stops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a visual Dot for each collapsed node in a trainrun sections chain (
trainrunSectionViewObject)Code picked from mrd/demo-intermediate-collapsed-dots
Might conflict a bit with #661