Handling of wrap-ignore with derived classes is wonky

[poshul]

wrap-ignore on SpectrumAccessTransforming breaks building of it's derived classes, this is wrong. There's pretty clearly a bug here in autowrap's handling of derived classes where the parent is wrap-ignored, but it's not a regression from previous behavior since earlier autowrap seems to have just ignored the annotation.

[jpfeuffer]

Btw: What is the error? I still have not seen a log of what is actually wrong.

[poshul]

Error compiling Cython file:
------------------------------------------------------------
...
from ._pyopenms_19 cimport MRMRTNormalizer
from ._pyopenms_19 cimport Sample
from ._pyopenms_19 cimport ModificationsDB
from ._pyopenms_20 cimport MSSpectrum
from ._pyopenms_20 cimport Acquisition
from ._pyopenms_20 cimport SpectrumAccessTransforming
^
------------------------------------------------------------

pyopenms/_pyopenms_21.pxd:1147:0: 'pyopenms/_pyopenms_20/SpectrumAccessTransforming.pxd' not found

Error compiling Cython file:
------------------------------------------------------------
...
from ._pyopenms_19 cimport MRMRTNormalizer
from ._pyopenms_19 cimport Sample
from ._pyopenms_19 cimport ModificationsDB
from ._pyopenms_20 cimport MSSpectrum
from ._pyopenms_20 cimport Acquisition
from ._pyopenms_20 cimport SpectrumAccessTransforming
^
------------------------------------------------------------

etc...

pyopenms/_pyopenms_21.pxd:1147:0: 'pyopenms/_pyopenms_20/SpectrumAccessTransforming.pxd' not found
Created all 32 pyopenms.cpps

[jpfeuffer]

Hmmm the whole file is not there? IS it because the file would be empty with the only class in the file being ignored? This is one guess.

[poshul]

the generated pxd file contains:

from SpectrumAccessTransforming cimport SpectrumAccessTransforming as _SpectrumAccessTransforming

...
from ._pyopenms_20 cimport SpectrumAccessTransforming

...
cdef class SpectrumAccessQuadMZTransforming:
    """
    Cython implementation of _SpectrumAccessQuadMZTransforming

    Original C++ documentation is available `here <http://www.openms.de/current_doxygen/html/classOpenMS_1_1SpectrumAccessQuadMZTransforming.html>`_
      -- Inherits from ['SpectrumAccessTransforming']
    """
    cdef shared_ptr[_SpectrumAccessQuadMZTransforming] inst
 

[poshul]

Hmmm the whole file is not there? IS it because the file would be empty with the only class in the file being ignored? This is one guess.

I'm confused about the error, because I'm not sure why it should be looking for a specific SpectrumAccessTransforming file at that point in the build, all of the stuff from the original pxds is already put into the _pyopen_XX.pxd. And as far as I can tell none of the other cimports that are properly in the _pyopenms_XX.pxds look for the original pxd file.

[poshul]

Hmmm the whole file is not there? IS it because the file would be empty with the only class in the file being ignored? This is one guess.

So, even if I wrap some SpectrumAccessTransforming functions (so that the class shouldn't be empty) I get the same error. adding the annotation # no-pxd-import fixes the import problem, and properly get the derived classes their imports.

So question:

• What is the no-pxd-import annotation?
• is ABSTRACT class an annotation? I see it several places, but it's not actually getting parsed as far as I can tell.

[jpfeuffer]

autowrap/autowrap/CodeGenerator.py

Lines 1952 to 1955 in 92598a8

	# Skip classes that explicitely should not have a pxd
	# import statement (abstract base classes and the like)
	if not resolved.no_pxd_import:
	if resolved.cpp_decl.annotations.get("wrap-attach"):

So it looks exactly like what we need. Should be better documented if it's not in the list of annotations in the docs.

[jpfeuffer]

Abstract class is just the reason for ignoring. it has no meaning.