Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the existing shimmer interface of weather and expose the api/json data in cleaner way. #10

Open
kumarrishav opened this issue Aug 21, 2016 · 3 comments

Comments

@kumarrishav
Copy link
Member

No description provided.

@kaichih
Copy link
Member

kaichih commented Aug 22, 2016

What will we improve exactly?

@kumarrishav
Copy link
Member Author

Right now, weather shimmer is returning the json object for each case like geolocation, atmosphere, forecast etc. If possible , we can try to make the shimmer method more intuitive .So that they don't have to parse much. For example, for weather forecast, it return array of 5 days forecast each having json object with 4-5 keys. So, basically i will try to simplify the interface (but it's not the priority right now) .

@kaichih
Copy link
Member

kaichih commented Aug 23, 2016

Got it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants