Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions in co-pilot cause logging to crash #131

Open
seamustuohy opened this issue Feb 17, 2016 · 0 comments
Open

Exceptions in co-pilot cause logging to crash #131

seamustuohy opened this issue Feb 17, 2016 · 0 comments
Labels

Comments

@seamustuohy
Copy link
Contributor

We need to switch over to flask style app based logging because Since Flask 0.8, if exceptions are not set to propagate, unhandled exceptions are sent to the application error log.

A quick fix would be to set PROPAGATE_EXCEPTIONS to True in the Flask config as this will enable propagation of exceptions to the python logging library. To avoid future pain it makes sense to push the logging to the app itself.

This may push all logging to the logs in /var/log/supervisor/copilot.... by pushing it through gunicorn. I don't have a problem with that even though debugging through /var/log/copilot.log and supervisor has been easier because of the separation of the logs so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant