Skip to content

Commit d86f6df

Browse files
author
Hans Zandbelt
committed
add TODO on preventing timing attacks
following new security considerations in JOSE specs
1 parent 6b800ae commit d86f6df

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/jose/apr_jwe.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,11 +316,13 @@ apr_byte_t apr_jwe_decrypt_jwt(apr_pool_t *pool, apr_jwt_header_t *header,
316316
if (apr_strnatcmp(header->alg, "RSA1_5") == 0) {
317317
if (apr_jwe_decrypt_cek_rsa(pool, header, unpacked_decoded, private_keys,
318318
&cek, &cek_len) == FALSE)
319+
// TODO: substitute dummy CEK to avoid timing attacks
319320
return FALSE;
320321
} else if ((apr_strnatcmp(header->alg, "A128KW") == 0)
321322
|| (apr_strnatcmp(header->alg, "A256KW") == 0)) {
322323
if (apr_jwe_cek_aes_unwrap_key(pool, header, unpacked_decoded,
323324
shared_key, &cek, &cek_len) == FALSE)
325+
// TODO: substitute dummy CEK to avoid timing attacks
324326
return FALSE;
325327
}
326328

0 commit comments

Comments
 (0)