Skip to content

Commit 3186676

Browse files
author
Hans Zandbelt
committed
make implicit post javascript HTML 4.01 Strict compliant
1 parent 69a3a97 commit 3186676

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/proto.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -968,18 +968,17 @@ int oidc_proto_javascript_implicit(request_rec *r, oidc_cfg *c) {
968968
// if (oidc_util_file_read(r, "/Users/hzandbelt/eclipse-workspace/mod_auth_openidc/src/implicit_post.html", &java_script) == FALSE) return HTTP_INTERNAL_SERVER_ERROR;
969969

970970
const char *java_script =
971-
"<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">\n"
972-
"<html xmlns=\"http://www.w3.org/1999/xhtml\" lang=\"en\" xml:lang=\"en\">\n"
971+
"<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01//EN\" \"http://www.w3.org/TR/html4/strict.dtd\">\n"
973972
" <head>\n"
974-
" <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\"/>\n"
973+
" <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\">\n"
975974
" <script type=\"text/javascript\">\n"
976975
" function postOnLoad() {\n"
977-
" encoded = location.hash.substring(1).split(\"&\");\n"
976+
" encoded = location.hash.substring(1).split('&');\n"
978977
" for (i = 0; i < encoded.length; i++) {\n"
979-
" encoded[i].replace(/\\+/g, \" \");\n"
980-
" var n = encoded[i].indexOf(\"=\");\n"
981-
" var input = document.createElement(\"input\");\n"
982-
" input.type = \"hidden\";\n"
978+
" encoded[i].replace(/\\+/g, ' ');\n"
979+
" var n = encoded[i].indexOf('=');\n"
980+
" var input = document.createElement('input');\n"
981+
" input.type = 'hidden';\n"
983982
" input.name = decodeURIComponent(encoded[i].substring(0, n));\n"
984983
" input.value = decodeURIComponent(encoded[i].substring(n+1));\n"
985984
" document.forms[0].appendChild(input);\n"
@@ -992,7 +991,7 @@ int oidc_proto_javascript_implicit(request_rec *r, oidc_cfg *c) {
992991
" </head>\n"
993992
" <body onload=\"postOnLoad()\">\n"
994993
" <p>Submitting...</p>\n"
995-
" <form method=\"post\"><input type=\"hidden\" name=\"response_mode\" value=\"fragment\"></form>\n"
994+
" <form method=\"post\" action=\"\"><p><input type=\"hidden\" name=\"response_mode\" value=\"fragment\"></p></form>\n"
996995
" </body>\n"
997996
"</html>\n";
998997

0 commit comments

Comments
 (0)