feign-kotlin: Decoder type returns "Object" when method is suspending

[JayPeaSize]

Currently using feign-kotlin 12.3 and kotlin 1.8.10 while attempting to use a custom decoder. When my method in the the TestClient is suspending type is printed out as "java.lang.Object" however, when not using suspend it returns the proper type of TestObject. This is currently preventing me from being able to get the proper serializer

Client Snippet:

public interface TestClient  {
    @RequestLine("GET /{uuid}")
    public suspend fun testGet(@Param("uuid") uuid: UUID): TestObject
}

Decoder snippet:

public class CustomDecoder: Decoder {
    override fun decode(response: Response, type: Type): Any? {
        if (response.status() != 404 && response.status() != 204) {
                ...
                println(type)
               ...
            }
        } else {
           ...
        }
    }
}

[kdavisk6]

I'm not Kotlin expert, but this appears to be an issue related to reflection. type in this case is java.lang.reflect.Type, so you may need to consider using Kotlin reflection to obtain the type. Here's an example I found that explains this situation.

https://blog.kotlin-academy.com/a-little-reflection-about-coroutines-34050cbc4fe6

So I'm not sure if this a bug in Feign Kotlin or an issue with your decoder.

[sunny-chung]

This issue is reproducible with the feign.jackson.JacksonDecoder from the io.github.openfeign:feign-jackson:12.4 dependency.

I set breakpoint at feign.Contract#parseAndValidateMetadata, and observed for a Kotlin suspend function signature like this:

suspend fun testGet(uuid: UUID): TestObject

It would translate to the following Java method signature:

public abstract java.lang.Object testGet(UUID, kotlin.coroutines.Continuation<TestObject>)

Currently, feign is taking the return type of the method as response type, but the generic parameter of the kotlin.coroutines.Continuation should be took instead.

It is not possible to implement any workaround in Decoder level, because feign passes java.lang.Object into the type parameter of the decode method.

[davidschreiber]

I'm running into the same issue, preventing me from using Feign (with Jackson) with suspending functions. This is definitely an issue on the level of Feign, since the reflection is incorrectly discarding the type information from client interfaces if suspending functions are used.

[kdavisk6]

To address this, we'd like to request that those in our community who are more familiar with Kotlin help us here. Anyone on this issue have experience and willing to try to correct it?

[dalcon10028]

I also faced the same problem. I hope this issue gets resolved quickly.

[velo]

I also faced the same problem. I hope this issue gets resolved quickly.

as soon you send a PR, it will be reviewed.