refactor(connectors): remove websocket URL audio playback

Author: DennisMoschina

open_wearable/docs/connectors/websocket-ipc-api.md

@@ -93,7 +93,7 @@ Other event messages:
 | `list_connected` | `{}` | `WearableSummary[]` |
 | `disconnect` | `{"device_id":string}` | `{"disconnected":true}` |
 | `store_sound` | `{"sound_id":string,"audio_base64":string,"codec"?:string,"sample_rate"?:int,"num_channels"?:int,"interleaved"?:bool,"buffer_size"?:int}` | `{"sound_id":string,"stored":true,"bytes":int,"config":object}` |
-| `play_sound` | `{"sound_id"?:string,"url"?:string,"volume"?:number,"codec"?:string,"sample_rate"?:int,"num_channels"?:int}` | `{"source":"sound_id"\\|"url","playing":true,"config":object,...}` |
+| `play_sound` | `{"sound_id":string,"volume"?:number,"codec"?:string,"sample_rate"?:int,"num_channels"?:int}` | `{"source":"sound_id","sound_id":string,"playing":true,"config":object}` |
 | `subscribe` | `{"device_id":string,"stream":string,"args"?:object}` | `{"subscription_id":int,"stream":string,"device_id":string}` |
 | `unsubscribe` | `{"subscription_id":int}` | `{"subscription_id":int,"cancelled":bool}` |
 | `invoke_action` | `{"device_id":string,"action":string,"args"?:object}` | depends on action |
@@ -141,10 +141,7 @@ Note:
 
 ## Audio Playback Over WebSocket
 
-The connector supports two audio modes:
-
-1. Distinct preloaded sounds (store once, play many times)
-2. Chunked audio stream playback (headphone-like continuous feed)
+The connector supports distinct preloaded sounds (store once, play many times).
 
 ### 1) Distinct Preloaded Sounds
 
@@ -174,23 +171,7 @@ Play a stored sound:
 }
 ```
 
-Play directly from a URL:
-
-```json
-{
-  "id": 22,
-  "method": "play_sound",
-  "params": {
-    "url": "https://example.com/notification.wav",
-    "volume": 1.0
-  }
-}
-```
-
-`play_sound` rules:
-
-- Provide exactly one source: `sound_id` or `url`.
-- If both are set, the server returns an error.
+`play_sound` requires `sound_id`.
 
 ## Data Shapes
 
@@ -268,4 +249,3 @@ Play directly from a URL:
 
 1. `store_sound` with `sound_id` and `audio_base64`.
 2. `play_sound` with the same `sound_id`.
-

open_wearable/lib/models/connectors/commands/play_sound_command.dart

@@ -9,7 +9,6 @@ class PlaySoundCommand extends RuntimeCommand {
           name: 'play_sound',
           params: [
             CommandParam<String>(name: 'sound_id'),
-            CommandParam<String>(name: 'url'),
             CommandParam<double>(name: 'volume'),
             CommandParam<String>(name: 'codec'),
             CommandParam<int>(name: 'sample_rate'),
@@ -20,16 +19,8 @@ class PlaySoundCommand extends RuntimeCommand {
   @override
   Future<Map<String, dynamic>> execute(List<CommandParam> params) {
     final soundId = readOptionalStringParam(params, 'sound_id');
-    final url = readOptionalStringParam(params, 'url');
-
-    if ((soundId == null || soundId.isEmpty) && (url == null || url.isEmpty)) {
-      throw ArgumentError('play_sound requires either "sound_id" or "url".');
-    }
-    if (soundId != null &&
-        soundId.isNotEmpty &&
-        url != null &&
-        url.isNotEmpty) {
-      throw ArgumentError('Provide either "sound_id" or "url", not both.');
+    if (soundId == null || soundId.isEmpty) {
+      throw ArgumentError('play_sound requires "sound_id".');
     }
 
     final config = AudioPlaybackConfig.fromOptional(
@@ -40,7 +31,6 @@ class PlaySoundCommand extends RuntimeCommand {
 
     return runtime.playSound(
       soundId: soundId,
-      url: url,
       volume: readOptionalDoubleParam(params, 'volume'),
       config: config,
     );

open_wearable/lib/models/connectors/commands/runtime.dart

@@ -41,7 +41,6 @@ abstract class CommandRuntime {
 
   Future<Map<String, dynamic>> playSound({
     String? soundId,
-    String? url,
     double? volume,
     AudioPlaybackConfig? config,
   });

open_wearable/lib/models/connectors/websocket_audio_playback_service.dart

@@ -1,8 +1,8 @@
 import 'dart:typed_data';
 
+import 'dart:io';
 import 'package:audioplayers/audioplayers.dart';
 import 'package:path_provider/path_provider.dart';
-import 'dart:io';
 
 import '../logger.dart';
 import 'audio_playback_config.dart';
@@ -68,49 +68,6 @@ class WebsocketAudioPlaybackService {
     return config;
   }
 
-  Future<AudioPlaybackConfig> playFromUrl({
-    required String url,
-    double? volume,
-    AudioPlaybackConfig? config,
-  }) async {
-    final uri = Uri.tryParse(url);
-    if (uri == null || !uri.hasScheme) {
-      throw ArgumentError('Invalid URL: $url');
-    }
-    if (uri.scheme != 'http' && uri.scheme != 'https') {
-      throw ArgumentError(
-        'Only http/https URLs are supported. Got: ${uri.scheme}',
-      );
-    }
-    if (uri.host == 'commons.wikimedia.org' &&
-        uri.path.startsWith('/wiki/File:')) {
-      throw ArgumentError(
-        'URL points to a Wikimedia page, not a direct audio file. Use the raw media URL from upload.wikimedia.org.',
-      );
-    }
-
-    final playbackConfig = config ?? const AudioPlaybackConfig();
-
-    if (volume != null) {
-      await _preloadedPlayer.setVolume(volume);
-    }
-
-    await _preloadedPlayer.stop();
-
-    try {
-      await _preloadedPlayer.play(UrlSource(url));
-    } catch (error) {
-      throw StateError(
-        'Failed to play URL source. Ensure it is a direct audio file URL (not an HTML page). Original error: $error',
-      );
-    }
-
-    logger.i(
-      '[connector.audio] playing url source=$url codec_hint=${playbackConfig.codec}',
-    );
-    return playbackConfig;
-  }
-
   Future<void> dispose() async {
     await _preloadedPlayer.dispose();
   }

open_wearable/lib/models/connectors/websocket_ipc_server.dart

@@ -336,41 +336,22 @@ class WebSocketIpcServer implements CommandRuntime {
   @override
   Future<Map<String, dynamic>> playSound({
     String? soundId,
-    String? url,
     double? volume,
     AudioPlaybackConfig? config,
   }) async {
     final hasSoundId = soundId != null && soundId.trim().isNotEmpty;
-    final hasUrl = url != null && url.trim().isNotEmpty;
-    if (!hasSoundId && !hasUrl) {
-      throw ArgumentError('play_sound requires either "sound_id" or "url".');
-    }
-    if (hasSoundId && hasUrl) {
-      throw ArgumentError('Provide either "sound_id" or "url", not both.');
+    if (!hasSoundId) {
+      throw ArgumentError('play_sound requires "sound_id".');
     }
 
-    if (hasSoundId) {
-      final usedConfig = await _audioPlaybackService.playStoredSound(
-        soundId: soundId,
-        volume: volume,
-        overrideConfig: config,
-      );
-      return <String, dynamic>{
-        'source': 'sound_id',
-        'sound_id': soundId,
-        'playing': true,
-        'config': usedConfig.toJson(),
-      };
-    }
-
-    final usedConfig = await _audioPlaybackService.playFromUrl(
-      url: url!,
+    final usedConfig = await _audioPlaybackService.playStoredSound(
+      soundId: soundId,
       volume: volume,
-      config: config,
+      overrideConfig: config,
     );
     return <String, dynamic>{
-      'source': 'url',
-      'url': url,
+      'source': 'sound_id',
+      'sound_id': soundId,
       'playing': true,
       'config': usedConfig.toJson(),
     };