Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][JAVA] Add @Nullable/@Nonnull annotations to clients #20804

Open
nvervelle opened this issue Mar 5, 2025 · 0 comments · May be fixed by #20806
Open

[REQ][JAVA] Add @Nullable/@Nonnull annotations to clients #20804

nvervelle opened this issue Mar 5, 2025 · 0 comments · May be fixed by #20806

Comments

@nvervelle
Copy link
Contributor

nvervelle commented Mar 5, 2025

I'm using java generator for webclient, and the generated clients do not contain @Nullable/@Nonnull annotations in the method parameters.

When using tools like NullAway, it causes some issues because you cannot easily use the clients when setting a nullable parameter, because the parameter is not annotated with @Nullable.

I'd like to add the annotations to the method parameters, so that it's easier to enable tools like NullAway on code using the generated clients.

Some time ago, I've added the annotations to the POJO (#19600 and #19617), so I will soon submit a PR to also add the annotations to the clients.

@nvervelle nvervelle linked a pull request Mar 5, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant