Skip to content

[BUG] [JAVA] [retrofit2] No serializationLibrary supplied → defunct generated code? #18812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 6 tasks
Philzen opened this issue May 31, 2024 · 1 comment
Closed
3 of 6 tasks

Comments

@Philzen
Copy link
Contributor

Philzen commented May 31, 2024

Discovered this while working on #18811.

Basically #16853 added the necessary checks for {{#gson}} or {{#jackson}} to the templates, but the generator code never set a proper default, so this bug was first released with 7.4.

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Suggest a fix

The RETROFIT_2 execution path in JavaClientCodegen needs to additionalProperties.put(SERIALIZATION_LIB_XY, "true").

@Philzen
Copy link
Contributor Author

Philzen commented May 31, 2024

This was a faulty assumption. Adding a test so one doesn't have to speculate in the future: d051d6f

@Philzen Philzen closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
@Philzen Philzen changed the title [BUG] [JAVA] [retrofit2] When serializationLibrary not supplied generated code is defunct [BUG] [JAVA] [retrofit2] ~~When serializationLibrary not supplied generated code is defunct~~ May 31, 2024
@Philzen Philzen changed the title [BUG] [JAVA] [retrofit2] ~~When serializationLibrary not supplied generated code is defunct~~ [BUG] [JAVA] [retrofit2] ~When serializationLibrary not supplied generated code is defunct~ May 31, 2024
@Philzen Philzen changed the title [BUG] [JAVA] [retrofit2] ~When serializationLibrary not supplied generated code is defunct~ [BUG] [JAVA] [retrofit2] No serializationLibrary supplied → defunct generated code? May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant