Fix bug with partial committing

Author: Jordonbc

Frontend/src/scripts/features/repo/filter.ts

@@ -8,7 +8,7 @@ export function bindFilter() {
     filterInput?.addEventListener('input', () => renderList());
     selectAllBox?.addEventListener('change', () => {
         if (prefs.tab !== 'changes') return;
-        state.defaultSelectAll = false;
+        disableDefaultSelectAll();
         const files = getVisibleFiles();
         toggleSelectAll(Boolean(selectAllBox?.checked), files);
         renderList();

Frontend/src/scripts/features/repo/hydrate.ts

@@ -27,8 +27,10 @@ export async function hydrateStatus() {
         state.files = Array.isArray(result?.files) ? (result.files as any) : [];
         const currentPaths = new Set((state.files || []).map((f) => f.path));
         if (state.defaultSelectAll) {
+            state.selectionImplicitAll = true;
             state.selectedFiles = new Set(Array.from(currentPaths));
         } else {
+            state.selectionImplicitAll = false;
             state.selectedFiles.forEach((p) => { if (!currentPaths.has(p)) state.selectedFiles.delete(p); });
         }
         (state as any).ahead = Number((result as any)?.ahead || 0);
@@ -39,6 +41,7 @@ export async function hydrateStatus() {
         console.warn('hydrateStatus failed', e);
         state.files = [];
         state.selectedFiles.clear();
+        state.selectionImplicitAll = false;
         renderList();
         window.dispatchEvent(new CustomEvent('app:status-updated'));
     }

Frontend/src/scripts/features/repo/interactions.ts

@@ -1,7 +1,7 @@
 import { buildCtxMenu, CtxItem } from '../../lib/menu';
 import { notify } from '../../lib/notify';
 import { TAURI } from '../../lib/tauri';
-import { state } from '../../state/state';
+import { state, disableDefaultSelectAll } from '../../state/state';
 import type { FileStatus } from '../../types';
 import { openStashConfirm } from '../stashConfirm';
 import { dragState, listEl } from './context';
@@ -33,7 +33,7 @@ export function onFileClick(e: MouseEvent, file: FileStatus, index: number, visi
             if (state.selectedFiles.has(p)) state.selectedFiles.delete(p);
             else state.selectedFiles.add(p);
         }
-        state.defaultSelectAll = false;
+        disableDefaultSelectAll();
         updateSelectAllState(visible);
         renderListAfterRangeSelect(file);
     } else if (isToggle) {
@@ -124,7 +124,7 @@ export function onFileMouseDown(e: MouseEvent, file: FileStatus, index: number,
 }
 
 export function applySelect(path: string, on: boolean, rowEl: HTMLElement | null, visible: FileStatus[], mode: 'diff' | 'commit') {
-    state.defaultSelectAll = false;
+    disableDefaultSelectAll();
     if (mode === 'commit') {
         if (on) state.selectedFiles.add(path); else state.selectedFiles.delete(path);
         if (rowEl) rowEl.classList.toggle('picked', on);

Frontend/src/scripts/state/state.ts

@@ -24,6 +24,7 @@ export const state = {
     behind: 0 as number,            // commits behind upstream
     aheadIds: new Set<string>() as Set<string>, // IDs of commits ahead of upstream
     defaultSelectAll: true as boolean, // by default select all files/hunks until user toggles
+    selectionImplicitAll: true as boolean, // true when select-all was auto-applied (no manual picks yet)
     // Selection state
     selectedFiles: new Set<string>(),
     currentFile: '' as string,
@@ -53,3 +54,15 @@ export const statusClass = (s: string) =>
     s === 'A' ? 'add' :
         s === 'M' ? 'mod' :
             s === 'D' ? 'del' : 'mod';
+
+// Disable the implicit "select all" mode. When clearImplicit is true, drop the
+// auto-filled selection set so later logic only sees explicit user picks.
+export function disableDefaultSelectAll(clearImplicit = false): boolean {
+    const hadImplicit = state.defaultSelectAll && state.selectionImplicitAll;
+    if (clearImplicit && hadImplicit) {
+        state.selectedFiles.clear();
+    }
+    state.defaultSelectAll = false;
+    state.selectionImplicitAll = false;
+    return Boolean(clearImplicit && hadImplicit);
+}