Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csolution] add_path: duplicate paths not checked, absolute paths not added #1938

Open
ReinhardKeil opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ReinhardKeil
Copy link
Collaborator

A *.cproject.yml that contains the following add-path:

  setups:
    - setup: Options for Target_1
      processor:
        fpu: "off"
      add-path:
        - $Pack(Microchip::SAME70_DFP)$/same70b/include
        - C:/Users/reikei01/AppData/Local/Arm/Packs/Microchip/SAME70_DFP/4.11.257/same71b/include

Generates this *.cbuild.yml output:

  add-path:
    - ${CMSIS_PACK_ROOT}/Microchip/SAME70_DFP/4.11.257/same70b/include
    - RTE/CMSIS
    - RTE/_Debug_Target_1
    - ${CMSIS_PACK_ROOT}/ARM/CMSIS-RTX/5.9.0/Include
    - ${CMSIS_PACK_ROOT}/ARM/CMSIS/6.1.0/CMSIS/Core/Include
    - ${CMSIS_PACK_ROOT}/ARM/CMSIS/6.1.0/CMSIS/RTOS2/Include
    - ${CMSIS_PACK_ROOT}/Microchip/SAME70_DFP/4.11.257/same70b/include     # !!! Duplicate

It has:

  • a duplicate path name (which is flagged by the schema)
  • misses the absolute include path C:/Users/reikei01/AppData/Local/Arm/Packs/Microchip/SAME70_DFP/4.11.257/same71b/include

The warning csolution: absolute path 'C:/Users/reikei01/AppData/Local/Arm/Packs/Microchip/SAME70_DFP/4.11.258/same70b/include' is not portable, use relative path instead is informative, but still the path should be in cbuild.yml add-path:.

To Reproduce

Use test.zip and use cbuild test.csolution.yml --context-set

Environment:

  • CMSIS-Toolbox 2.7.0
  • OS: Windows
@ReinhardKeil ReinhardKeil added the bug Something isn't working label Jan 29, 2025
@ReinhardKeil ReinhardKeil changed the title add_path: duplicate paths not check, absolute paths not added add_path: duplicate paths not checked, absolute paths not added Feb 3, 2025
@jkrech jkrech changed the title add_path: duplicate paths not checked, absolute paths not added [csolution] add_path: duplicate paths not checked, absolute paths not added Feb 4, 2025
@brondani brondani moved this from Todo to In Progress in CMSIS-Toolbox 2.8.0 Feb 13, 2025
edriouk pushed a commit that referenced this issue Feb 18, 2025
…hs (#1142) (#1970)

Address #1938
Update test cases

Co-authored-by: Daniel Brondani <[email protected]>
@brondani brondani moved this from In Progress to Done in CMSIS-Toolbox 2.8.0 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants