Updated tests for non-prod changes

* Updated getCanonicalSubscriptionUrls tests
* localhost and staging only support one domain
* Fixes 2 tests that PR #620 broke
https://travis-ci.org/github/OneSignal/OneSignal-Website-SDK/builds/672001235?utm_source=github_status

Author: jkasten2

test/unit/managers/AltOriginManager.ts

@@ -12,35 +12,35 @@ test(`should get correct canonical subscription URL for development environment`
   config.httpUseOneSignalCom = true;
 
   const devUrlsOsTcDomain = AltOriginManager.getCanonicalSubscriptionUrls(config, EnvironmentKind.Development);
-  t.is(devUrlsOsTcDomain.length, 2);
+  t.is(devUrlsOsTcDomain.length, 1);
   t.is(devUrlsOsTcDomain[0].host, new URL('https://test.localhost:3001').host);
-  t.is(devUrlsOsTcDomain[1].host, new URL('https://test.os.tc:3001').host);
 
   config.httpUseOneSignalCom = false;
 
   const devUrls = AltOriginManager.getCanonicalSubscriptionUrls(config, EnvironmentKind.Development);
   t.is(devUrls.length, 1);
-  t.is(devUrls[0].host, new URL('https://test.os.tc:3001').host);
+  t.is(devUrls[0].host, new URL('https://test.localhost:3001').host);
 });
 
 test(`should get correct canonical subscription URL for staging environment`, async t => {
+  const stagingDomain = "staging.onesignal.com";
+  (<any>global).__API_ORIGIN__ = stagingDomain; 
   const config = TestEnvironment.getFakeAppConfig();
   config.subdomain = 'test';
   config.httpUseOneSignalCom = true;
 
   const browser = await TestEnvironment.stubDomEnvironment();
-  browser.changeURL(window, "http://staging-01.onesignal.com");
+  browser.changeURL(window, `http://${stagingDomain}`);
 
   const stagingUrlsOsTcDomain = AltOriginManager.getCanonicalSubscriptionUrls(config, EnvironmentKind.Staging);
-  t.is(stagingUrlsOsTcDomain.length, 2);
-  t.is(stagingUrlsOsTcDomain[0].host, new URL('https://test.staging-01.onesignal.com').host);
-  t.is(stagingUrlsOsTcDomain[1].host, new URL('https://test.os.tc').host);
+  t.is(stagingUrlsOsTcDomain.length, 1);
+  t.is(stagingUrlsOsTcDomain[0].host, new URL(`https://test.${stagingDomain}`).host);
 
+  // staging does not support an alt domain so it should be the same.
   config.httpUseOneSignalCom = false;
-
   const stagingUrls = AltOriginManager.getCanonicalSubscriptionUrls(config, EnvironmentKind.Staging);
   t.is(stagingUrls.length, 1);
-  t.is(stagingUrls[0].host, new URL('https://test.os.tc').host);
+  t.is(stagingUrls[0].host, new URL(`https://test.${stagingDomain}`).host);
 });
 
 test(`should get correct canonical subscription URL for production environment`, async t => {
@@ -50,8 +50,8 @@ test(`should get correct canonical subscription URL for production environment`,
 
   const prodUrlsOsTcDomain = AltOriginManager.getCanonicalSubscriptionUrls(config, EnvironmentKind.Production);
   t.is(prodUrlsOsTcDomain.length, 2);
-  t.is(prodUrlsOsTcDomain[0].host, new URL('https://test.onesignal.com').host);
-  t.is(prodUrlsOsTcDomain[1].host, new URL('https://test.os.tc').host);
+  t.is(prodUrlsOsTcDomain[0].host, new URL('https://test.os.tc').host);
+  t.is(prodUrlsOsTcDomain[1].host, new URL('https://test.onesignal.com').host);
 
   config.httpUseOneSignalCom = false;
 

test/unit/modules/sdkEnvironment.ts

@@ -71,6 +71,8 @@ test('API URL should be valid for development environment', async t => {
 });
 
 test('API URL should be valid for staging environment', async t => {
+  const browser = await TestEnvironment.stubDomEnvironment();
+  browser.changeURL(window, "https://localhost");
   const expectedUrl = `https://${window.location.host}/api/v1`;
   t.is(SdkEnvironment.getOneSignalApiUrl(EnvironmentKind.Staging).toString(), expectedUrl);
 });