Only send subscription deltas (payload in operation) for update sub

Motivation: when updating a subscription, we can send only the `deltas`. While sending the entire object also works, this is a better implementation.

Author: rgomezp

src/core/requestService/SubscriptionRequests.ts

@@ -41,14 +41,19 @@ export default class SubscriptionRequests {
   static async updateSubscription<Model>(operation: Operation<Model>): Promise<ExecutorResult<SupportedSubscription>> {
     logMethodCall("SubscriptionRequests.updateSubscription", operation);
 
-    const { subscription, subscriptionId } = processSubscriptionOperation(operation);
+    const { payload, subscriptionId } = processSubscriptionOperation(operation);
 
     if (!subscriptionId) {
       throw new OneSignalError("updateSubscription: subscriptionId is not defined");
     }
+
+    if (!payload) {
+      throw new OneSignalError("updateSubscription: payload is not defined");
+    }
+
     const appId = await MainHelper.getAppId();
 
-    const response = await RequestService.updateSubscription({ appId }, subscriptionId, subscription);
+    const response = await RequestService.updateSubscription({ appId }, subscriptionId, payload);
     return SubscriptionRequests._processSubscriptionResponse(response);
   }
 

src/core/requestService/helpers.ts

@@ -11,6 +11,7 @@ export function processSubscriptionOperation<Model>(operation: Operation<Model>)
   subscription: SupportedSubscription;
   aliasPair: AliasPair;
   subscriptionId?: string;
+  payload?: Partial<SupportedSubscription>
 } {
   const subscriptionOSModel = operation.model;
   const subscription = subscriptionOSModel?.data;
@@ -25,20 +26,21 @@ export function processSubscriptionOperation<Model>(operation: Operation<Model>)
     throw new OneSignalError(`processSubscriptionModel: bad subscription object: ${JSON.stringify(subscription)}`);
   }
 
-  let subscriptionId;
-  if (isCompleteSubscriptionObject(subscription)) {
-    subscriptionId = subscription?.id;
-  }
-
   // fixes typescript errors
   if (!subscriptionOSModel.onesignalId) {
     throw new OneSignalError(`processSubscriptionModel: missing onesignalId: ${JSON.stringify(subscriptionOSModel)}`);
   }
 
+  let subscriptionId;
+  if (isCompleteSubscriptionObject(subscription)) {
+    subscriptionId = subscription?.id;
+  }
+
   return {
     subscription,
     aliasPair: new AliasPair(AliasPair.ONESIGNAL_ID, subscriptionOSModel.onesignalId),
     subscriptionId,
+    payload: operation.payload as Partial<SupportedSubscription>
   };
 }