Updated Android SDK to 3.12.2

* Changed iOS stubs to WARN logs
* Added checks for OutcomeEvent so it does not crash when parsing null or null attributes

Author: mikechoch

android/build.gradle

@@ -34,7 +34,7 @@ android {
 }
 
 dependencies {
-    api 'com.onesignal:OneSignal:3.12.1'
+    api 'com.onesignal:OneSignal:3.12.2'
 }
 
 // Adds required manifestPlaceholders keys to allow mainifest merge gradle step to complete

android/src/main/java/com/onesignal/flutter/OneSignalOutcomeEventsController.java

@@ -1,8 +1,11 @@
 package com.onesignal.flutter;
 
+import androidx.annotation.Nullable;
+
 import com.onesignal.OneSignal;
 import com.onesignal.OutcomeEvent;
 
+import java.util.HashMap;
 import java.util.concurrent.atomic.AtomicBoolean;
 
 import io.flutter.plugin.common.MethodCall;
@@ -27,12 +30,16 @@ class OSFlutterOutcomeEventsHandler extends FlutterRegistrarResponder implements
     }
 
     @Override
-    public void onSuccess(OutcomeEvent outcomeEvent) {
+    public void onSuccess(@Nullable OutcomeEvent outcomeEvent) {
         if (this.replySubmitted.getAndSet(true))
             return;
 
-        replySuccess(result, OneSignalSerializer.convertOutcomeEventToMap(outcomeEvent));
+        if (outcomeEvent == null)
+            replySuccess(result, new HashMap<>());
+        else
+            replySuccess(result, OneSignalSerializer.convertOutcomeEventToMap(outcomeEvent));
     }
+
 }
 
 public class OneSignalOutcomeEventsController extends FlutterRegistrarResponder implements MethodCallHandler {

android/src/main/java/com/onesignal/flutter/OneSignalSerializer.java

@@ -201,7 +201,12 @@ static HashMap<String, Object> convertOutcomeEventToMap(OutcomeEvent outcomeEven
         HashMap<String, Object> hash = new HashMap<>();
 
         hash.put("session", outcomeEvent.getSession().toString());
-        hash.put("notification_ids", outcomeEvent.getNotificationIds().toString());
+
+        if (outcomeEvent.getNotificationIds() == null)
+            hash.put("notification_ids", new JSONArray().toString());
+        else
+            hash.put("notification_ids", outcomeEvent.getNotificationIds().toString());
+
         hash.put("id", outcomeEvent.getName());
         hash.put("timestamp", outcomeEvent.getTimestamp());
         hash.put("weight", String.valueOf(outcomeEvent.getWeight()));

example/lib/main.dart

@@ -269,6 +269,9 @@ class _MyAppState extends State<MyApp> {
   }
 
   oneSignalOutcomeEventsExamples() async {
+    // Await example for sending outcomes
+    outcomeAwaitExample();
+
     // Send a normal outcome and get a reply with the name of the outcome
     OneSignal.shared.sendOutcome("normal_1");
     OneSignal.shared.sendOutcome("normal_2").then((outcomeEvent) {
@@ -291,6 +294,11 @@ class _MyAppState extends State<MyApp> {
     });
   }
 
+  Future<void> outcomeAwaitExample() async {
+      var outcomeEvent = await OneSignal.shared.sendOutcome("await_normal_1");
+      print(outcomeEvent.jsonRepresentation());
+  }
+
   @override
   Widget build(BuildContext context) {
     return new MaterialApp(

ios/Classes/OneSignalOutcomeEventsController.m

@@ -54,20 +54,20 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
 
 - (void)sendOutcome:(FlutterMethodCall *)call withResult:(FlutterResult)result {
 //    NSString *name = call.arguments;
-    [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Method sendOutcome() not implemented for iOS yet!"];
+    [OneSignal onesignal_Log:ONE_S_LL_WARN message:@"Method sendOutcome() not implemented for iOS yet!"];
     result(@{});
 }
 
 - (void)sendUniqueOutcome:(FlutterMethodCall *)call withResult:(FlutterResult)result {
 //    NSString *name = call.arguments;
-    [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Method sendUniqueOutcome() not implemented for iOS yet!"];
+    [OneSignal onesignal_Log:ONE_S_LL_WARN message:@"Method sendUniqueOutcome() not implemented for iOS yet!"];
     result(@{});
 }
 
 - (void)sendOutcomeWithValue:(FlutterMethodCall *)call withResult:(FlutterResult)result {
 //    NSString *name = call.arguments[@"outcome_name"];
 //    NSNumber *value = call.arguments[@"outcome_value"];
-    [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Method sendOutcomeWithValue() not implemented for iOS yet!"];
+    [OneSignal onesignal_Log:ONE_S_LL_WARN message:@"Method sendOutcomeWithValue() not implemented for iOS yet!"];
     result(@{});
 }