Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with Computers #5

Open
BboyZeroOne opened this issue Jul 26, 2020 · 18 comments
Open

Bug with Computers #5

BboyZeroOne opened this issue Jul 26, 2020 · 18 comments

Comments

@BboyZeroOne
Copy link

In some cases, the NBT tags data of the computers just increased out of the blue, that has not been placed down before. Please take a look.

Plugin Ver: 2.4
Server Ver: 1.15.2 PaperSpigot

Working: 2 NBT
unknown10

Broke: 3NBT
unknown11

Additional Issues:

  1. When Computers are mined with Telepathy enchanted pickaxe, the Computer will be broken.
  2. When Computers are mined with Experience enchanted pickaxe, it will give out exp.
    Plugin: https://www.spigotmc.org/resources/%E2%AD%95%EF%B8%8F-advancedenchantments-%E2%9C%85-create-custom-enchants-%E2%9C%A8-195-enchants-%E2%AD%90-1-8-1-16-30-sale.43058/
@OfficialDonut
Copy link
Owner

Command blocks can't be mined in survival?

@BboyZeroOne
Copy link
Author

Players are not supposed to mine command blocks with pickaxes, but this enchantment plugin bypass the mining prevention.

Telepathy: "Automatically places blocks broken by tools in your inventory."

@OfficialDonut
Copy link
Owner

So then it's a bug of the enchantment plugin?

@BboyZeroOne
Copy link
Author

So then it's a bug of the enchantment plugin?

I believe Bitcoin plugin should negate the effects from the enchantment plugin.

@BboyZeroOne
Copy link
Author

For the first case regarding NBT tags increasing, its random and out of the blue. Although players have never use/place it.

@OfficialDonut
Copy link
Owner

I believe Bitcoin plugin should negate the effects from the enchantment plugin.

Bitcoin shouldn't have to make changes to accommodate plugins that change mc mechanics

For the first case regarding NBT tags increasing, its random and out of the blue. Although players have never use/place it.

I'm not sure what would cause that, are you sure its bitcoin? Can you use the /data command or something to view the nbt and see what is being added?

@BboyZeroOne
Copy link
Author

Bitcoin shouldn't have to make changes to accommodate plugins that change mc mechanics

It would be great if it does, so it would be compatible with servers that uses custom enchantments that modify mc mechanics.

I'm not sure what would cause that, are you sure its bitcoin? Can you use the /data command or something to view the nbt and see what is being added?

Here
image

@OfficialDonut
Copy link
Owner

I dont see anything out of the ordinary, does it work fine?

@BboyZeroOne
Copy link
Author

Nope it doesn't. It is the Computer that has 3 tags (Broken).

Here is the one that has 2 tags (Working).
image

@BboyZeroOne
Copy link
Author

Additional Issue:
In some cases, players who did not complete the puzzle has their name on the top list as shown.
unknown14

@OfficialDonut
Copy link
Owner

I found the problem with the top list, but I cannot reproduce the nbt issue.

Another thought, would it be better if computers didn't have to be placed to be used ie you just click the item in your inventory to use it? I think that would be more user friendly and also solve the conflict with the enchantment plugin.

@BboyZeroOne
Copy link
Author

BboyZeroOne commented Jul 27, 2020

Another thought, would it be better if computers didn't have to be placed to be used ie you just click the item in your inventory to use it? I think that would be more user friendly and also solve the conflict with the enchantment plugin.

If so, then I believe Bitcoin should prevent players from placing it down on the floor to prevent such issue from happening. It would be great if there is a config option to enable or disable placing of Computers.

@OfficialDonut
Copy link
Owner

OfficialDonut commented Jul 27, 2020

Bitcoin should prevent players from placing it down on the floor

Players normally can't place command blocks in survival, bitcoin currently makes it so they can.

@BboyZeroOne
Copy link
Author

Players normally can't place command blocks in survival, bitcoin currently makes it so they can.

They can't place a normal command block in survival, but only a Computer command block.

@OfficialDonut
Copy link
Owner

OfficialDonut commented Jul 27, 2020

They can't place a normal command block in survival, but only a Computer command block.

Right that's what I meant. I will make it so players can't place computers and must click while holding it to use it.

@BboyZeroOne
Copy link
Author

They can't place a normal command block in survival, but only a Computer command block.

Right that's what I meant. I will make it so players can't place computers and must click while holding it to use it.

Awesome! I think that might fix the issue.

@OfficialDonut
Copy link
Owner

Updated: https://www.spigotmc.org/resources/bitcoin.52085/update?update=351150. Please close the issue if everything is resolved.

@BboyZeroOne
Copy link
Author

Alright, thank you! I will test it out and let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants