Migrating to .NET 8 (#617)

* Migrating to .net8 from .net6

* Better handling of SYSLIB0051

* Improved handling of VSTHRD103 and other pragmas

* Fix to update target in Halibut build schema

* Disable dotMemory Unit tests on net8.0 builds

* Disable memory dumps

* Add env var workaround for .NET7+ virtual memory alloc

* No need to get the runtime as well

* Add env var to skip backwards compat test

* Add env override to ignore duplicated loggers

* Restore test blame behaviour

* Don't ignore duplicated loggers

* Propagate, rather than hardcode GC hard limit

* Major version bump

+semver: major

* Remove obsolete files from solution

* Add stub WindowsNet60 target

* Update Nuke build schema

* Remove extraneous comma

* Fix some comments

---------

Co-authored-by: Adrian Codrington <[email protected]>
Co-authored-by: Rhys Parry <[email protected]>

Author: 3 people

.nuke/build.schema.json

@@ -87,7 +87,7 @@
               "Clean",
               "Compile",
               "CompileNet48",
-              "CompileNet60",
+              "CompileNet80",
               "CopyToLocalPackages",
               "Default",
               "Pack",
@@ -96,7 +96,8 @@
               "TestLinux",
               "TestWindows",
               "TestWindowsNet48",
-              "TestWindowsNet60"
+              "TestWindowsNet60",
+              "TestWindowsNet80"
             ]
           }
         },
@@ -113,7 +114,7 @@
               "Clean",
               "Compile",
               "CompileNet48",
-              "CompileNet60",
+              "CompileNet80",
               "CopyToLocalPackages",
               "Default",
               "Pack",
@@ -122,7 +123,8 @@
               "TestLinux",
               "TestWindows",
               "TestWindowsNet48",
-              "TestWindowsNet60"
+              "TestWindowsNet60",
+              "TestWindowsNet80"
             ]
           }
         },

build.ps1

@@ -65,10 +65,6 @@ else {
     } else {
         ExecSafe { & powershell $DotNetInstallFile -InstallDir $DotNetDirectory -Version $DotNetVersion -NoPath }
     }
-    # Octopus Modification
-    # Install the .NET 6.0 runtime as well (this is required to run the tests)
-    ExecSafe { & powershell $DotNetInstallFile -InstallDir $DotNetDirectory -Runtime dotnet -Channel 6.0 -NoPath }
-    # End Octopus Modification
     $env:DOTNET_EXE = "$DotNetDirectory\dotnet.exe"
 }
 

build.sh

@@ -54,10 +54,6 @@ else
         "$DOTNET_INSTALL_FILE" --install-dir "$DOTNET_DIRECTORY" --version "$DOTNET_VERSION" --no-path
     fi
 
-    # Octopus Modification
-    # Install the .NET 6.0 runtime as well (this is required to run the tests)
-    "$DOTNET_INSTALL_FILE" --install-dir "$DOTNET_DIRECTORY" --runtime dotnet --channel 6.0 --no-path
-    # End Octopus Modification
     export DOTNET_EXE="$DOTNET_DIRECTORY/dotnet"
 fi
 

build/Build.cs

@@ -81,7 +81,7 @@ class Build : NukeBuild
 
     Target CompileNet48 => _ => CompileDefinition(_, "net48");
 
-    Target CompileNet60 => _ => CompileDefinition(_, "net6.0");
+    Target CompileNet80 => _ => CompileDefinition(_, "net8.0");
 
     ITargetDefinition CompileDefinition(ITargetDefinition targetDefinition, [CanBeNull] string framework)
     {
@@ -100,7 +100,7 @@ ITargetDefinition CompileDefinition(ITargetDefinition targetDefinition, [CanBeNu
     }
 
     [PublicAPI]
-    Target TestWindows => _ => TestDefinition(_, Compile, null, runDotMemoryTests: true);
+    Target TestWindows => _ => TestDefinition(_, Compile, null, runDotMemoryTests: false);
 
     [PublicAPI]
     Target TestLinux => _ => TestDefinition(_, Compile, null, runDotMemoryTests: false);
@@ -109,7 +109,12 @@ ITargetDefinition CompileDefinition(ITargetDefinition targetDefinition, [CanBeNu
     Target TestWindowsNet48 => _ => TestDefinition(_, CompileNet48, "net48", runDotMemoryTests: true);
 
     [PublicAPI]
-    Target TestWindowsNet60 => _ => TestDefinition(_, CompileNet60, "net6.0", runDotMemoryTests: true);
+    Target TestWindowsNet80 => _ => TestDefinition(_, CompileNet80, "net8.0", runDotMemoryTests: false);
+
+    // This temporary target is included to run the net8 tests on a pipeline configured for net6.0
+    // It can be removed once the build pipeline is updated to reference the new target.
+    [PublicAPI]
+    Target TestWindowsNet60 => t => t.DependsOn(TestWindowsNet80);
 
     ITargetDefinition TestDefinition(ITargetDefinition targetDefinition, Target dependsOn, [CanBeNull] string framework, bool runDotMemoryTests)
     {

source/Halibut.TestProxy/Halibut.TestProxy.csproj

@@ -8,10 +8,10 @@
   </PropertyGroup>
 
   <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())">
-    <TargetFrameworks>net48;net6.0</TargetFrameworks>
+    <TargetFrameworks>net48;net8.0</TargetFrameworks>
   </PropertyGroup>
   <PropertyGroup Condition="$([MSBuild]::IsOSUnixLike())">
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFramework>net8.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>

source/Halibut.TestProxy/TcpListenerHelpers.cs

@@ -36,7 +36,7 @@ public static async Task<TcpListener> GetTcpListener(string listenEndpoint)
             throw new ArgumentException($"Listening endpoint '{listenEndpoint}' could not be parsed");
         }
 
-        // Taken from net6.0 and adapted to support net48
+        // Taken from net8.0 and adapted to support net48
         public static bool TryParse(string s, out IPEndPoint? result)
         {
             int addressLength = s.Length;  // If there's no port then send the entire string to the address parser

source/Halibut.TestUtils.CompatBinary.Base/Halibut.TestUtils.CompatBinary.Base.csproj

@@ -8,10 +8,10 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())">
-        <TargetFrameworks>net48;net6.0</TargetFrameworks>
+        <TargetFrameworks>net48;net8.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup Condition="$([MSBuild]::IsOSUnixLike())">
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
     </PropertyGroup>
     <ItemGroup>
       <Compile Include="..\Halibut.Tests\Support\TcpPortHelper.cs" Link="TcpPortHelper.cs" />

source/Halibut.TestUtils.CompatBinary.v4_4_8/Halibut.TestUtils.CompatBinary.v4_4_8.csproj

@@ -9,10 +9,10 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())">
-        <TargetFrameworks>net48;net6.0</TargetFrameworks>
+        <TargetFrameworks>net48;net8.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup Condition="$([MSBuild]::IsOSUnixLike())">
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
     </PropertyGroup>
 
     <ItemGroup>

source/Halibut.TestUtils.CompatBinary.v5_0_236/Halibut.TestUtils.CompatBinary.v5_0_236.csproj

@@ -9,10 +9,10 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())">
-        <TargetFrameworks>net48;net6.0</TargetFrameworks>
+        <TargetFrameworks>net48;net8.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup Condition="$([MSBuild]::IsOSUnixLike())">
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
     </PropertyGroup>
 
     <ItemGroup>

source/Halibut.TestUtils.CompatBinary.v6_0_658/Halibut.TestUtils.CompatBinary.v6_0_658.csproj

@@ -9,10 +9,10 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())">
-        <TargetFrameworks>net48;net6.0</TargetFrameworks>
+        <TargetFrameworks>net48;net8.0</TargetFrameworks>
     </PropertyGroup>
     <PropertyGroup Condition="$([MSBuild]::IsOSUnixLike())">
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
     </PropertyGroup>
 
     <ItemGroup>