Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country names not in line with openentrance definitions #38

Closed
HauHe opened this issue Nov 23, 2023 · 3 comments
Closed

Country names not in line with openentrance definitions #38

HauHe opened this issue Nov 23, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@HauHe
Copy link
Contributor

HauHe commented Nov 23, 2023

When trying to upload results to the IIASA ScenarioExplorer I noticed that the recent fixes on country names are not in line with the definitions in the openentrance package.

We report OpenEntrance requires
Netherlands The Netherlands
Czechia Czech Republic
United Kingdom of Great Britain and Northern Ireland United Kingdom
@HauHe HauHe added the bug Something isn't working label Nov 23, 2023
@danielhuppmann
Copy link
Contributor

You are right, "Czechia" is a relatively new change, the other two items are very common problems.

And yes, in openENTRANCE, we use an older list of country names, which we are currently trying to standardize across projects at https://nomenclature-iamc.readthedocs.io/en/stable/api/countries.html.

My suggestion is that you implement all reporting using the nomenclature country names (Netherlands, Czechia, United Kingdom) and I add a "manual" translation in the openENTRANCE workflow to ensure compatibility in that project. Sounds ok?

@HauHe
Copy link
Contributor Author

HauHe commented Dec 5, 2023

Hi Daniel,
yes, we will create a fix so that we report with the country names used in openEntrance, i.e. the Netherlands, Czech Republic etc.

@HauHe HauHe mentioned this issue Dec 5, 2023
@willu47
Copy link
Member

willu47 commented Dec 7, 2023

Closed by #40

@willu47 willu47 closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants