Feature/fdp 3254 oslp signing library #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gradle/libs.versions.toml
Signed-off-by: JelleHoffman <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jelle Hoffman <[email protected]>
Signed-off-by: Sander van der Heijden <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates an external OSLP message signing library to replace the existing custom signing implementation, adding dependency on com.gxf.utilities:oslp-message-signing library.
- Replaces custom
SigningUtilobject with external signing library integration - Refactors key management to implement
KeyProviderinterface from the external library - Updates build configuration to include the new signing library dependency
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Removes custom plugin and dependency management configurations |
| gradle/libs.versions.toml | Adds version declarations for the new signing library |
| composeApp/src/desktopMain/kotlin/org/lfenergy/gxf/oslp/util/OslpSigningUtil.kt | New wrapper class extending the external SigningUtil |
| composeApp/src/desktopMain/kotlin/org/lfenergy/gxf/oslp/util/OslpKeyProvider.kt | Refactors existing SigningUtil to implement KeyProvider interface |
| composeApp/src/desktopMain/kotlin/org/lfenergy/gxf/oslp/sockets/receive/ReceiveStrategy.kt | Updates to use new OslpSigningUtil wrapper |
| composeApp/src/desktopMain/kotlin/org/lfenergy/gxf/oslp/service/RequestService.kt | Updates to use new OslpSigningUtil wrapper |
| composeApp/src/desktopMain/kotlin/org/lfenergy/gxf/oslp/Main.kt | Updates initialization to use the new signing utility |
| composeApp/proguard-rules.pro | Adds ProGuard rules for the new library and suppresses warnings |
| composeApp/build.gradle.kts | Adds dependency on the new signing library |
| .github/workflows/build.yaml | Adds GitHub token environment variable for private registry access |
| .github/dependabot.yaml | Configures Dependabot to access private Maven registry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| if (isConfigured) { | ||
| if (OslpSigningUtil.getInstance().oslpKeyProvider.initializeKeys()) { | ||
| config.storeConfiguration() |
There was a problem hiding this comment.
This change removes the assignment to isConfigured variable. The variable isConfigured is likely used elsewhere in the code, and this change may break the configuration flow logic.
Suggested change
| config.storeConfiguration() | |
| config.storeConfiguration() | |
| isConfigured = true |
| type: maven-repository | ||
| url: https://maven.pkg.github.com/osgp/ | ||
| username: IoTFDP | ||
| password: ${{secrets.IOTFDP_GITHUB_TOKEN}} |
There was a problem hiding this comment.
The secret reference uses incorrect syntax. GitHub Actions secrets should be referenced as ${{ secrets.SECRET_NAME }} (with spaces around the braces), not ${{secrets.SECRET_NAME}}.
Suggested change
| password: ${{secrets.IOTFDP_GITHUB_TOKEN}} | |
| password: ${{ secrets.IOTFDP_GITHUB_TOKEN }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.