Smart-data-models: Committing PR for support range value

[andreasDroid]

Hi @janhalen and @sobuos

I'm preparing a PR for the smart-data-models transportation, specifically on the VehicleModel.

I would like to get your take on the required contributions before I commit.

I suggest a property tractionBatteryCapacity, which is a number field to capture the total capacity of a battery that is used for powering the vehicle.
From that value we can, together with the fuelConsumption, calculate a range for electrical vehicles.

Required files for a PR are the following:

• schema.json
• example.json
• example-normalized.json
• example.jsonld
• example-normalized.jsonld
• ADOPTERS.yaml (optional, but discouraged)

and then I need to sign a contribution agreement

Suggested addition to the schema:

        "tractionBatteryCapacity": {
          "type": "number",
          "minimum": 0,
          "description": "Property. Vehicle's traction battery capacity. Applies to electrically powered vehicles (e.g. 52 kWh)"
        },

Suggested ADOPTERS.yaml:

 adopter: OS2 GPS-Connector
 description: Open source project for danish municipalities to collect GPS data for analysis and optimisation
 mail: 
 organization: https://www.os2.eu/
 project: https://github.com/OS2sandbox/gps-connector
 comments: Storing additional meta-data for vehicle models, such as 'tractionBatteryCapacity', allows further optimisation by calculating range for BEV.
 startDate: 

[andreasDroid]

See the suggested changes here:

smart-data-models/dataModel.Transportation@master...andreasDroid:dataModel.Transportation:tractionBatteryCapacity

examples are not applicable since the included example is a fossil vehicle.

[janhalen]

Im surprised that we are the first to introduce electrical vehicles?

But its looking like a solid PR...

Only suggestion would be to make it clearer that it wasnt a personal contribution but one made possible by financing from OS2.

Lets see how fast they respond...

[andreasDroid]

I'm assuming you're refering to the CONTRIBUTORS.yaml

I'm fine with updating it like

  - name: 
    surname:
    mail:
    organization: OS2.eu
    project: OS2 GPS-Connector
    comments: Project funded by OS2 for danish municipalities. 
    year: 2025

[janhalen]

I'm assuming you're refering to the CONTRIBUTORS.yaml

I'm fine with updating it like

  - name: 
    surname:
    mail:
    organization: OS2.eu
    project: OS2 GPS-Connector
    comments: Project funded by OS2 for danish municipalities. 
    year: 2025

yeah.. great additions to the organisation fields..

How strict is the yaml schema do you feel? Could additional fileds be added without breaking autimation / validation?

I miss some sort of seperation of the host organisation and the actual developer/supplier.. well..

Anyway... You can toot your horn and add your name to the name fields, i think you should.

... the mail could be os2fleetoptimiser@os2.eu ..

GA 👍🏻

[andreasDroid]

PR has been commited smart-data-models/dataModel.Transportation#33

[andreasDroid]

PR commit in the incubated repo smart-data-models/incubated#275

[janhalen]

@andreasDroid: Hmm i have tagged an organization member on github and have asked for directions...

I digged a little bit and found this slide with contact info:

Maybe that is another "way in" to get the PR review process kickstarted?

Taken from this "Manual" (a google slide) --> https://docs.google.com/presentation/d/e/2PACX-1vTs-Ng5dIAwkg91oTTUdt8ua7woBXhPnwavZ0FxgR8BsAI_Ek3C5q97Nd94HS8KhP-r_quD4H0fgyt3/pub?start=false&loop=false&delayms=3000#slide=id.g280421d2344_1_1903

[janhalen]

Oh.. and they even have a more general "submit issue" on their frontpage... Its not because we lack points of contact 😄

https://smartdatamodels.org/index.php/submit-an-issue/