Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace error #56

Open
rossdwilliams opened this issue Mar 18, 2020 · 2 comments
Open

whitespace error #56

rossdwilliams opened this issue Mar 18, 2020 · 2 comments

Comments

@rossdwilliams
Copy link
Collaborator

rossdwilliams commented Mar 18, 2020

If there is whitespace in a cohort name then this causes the sql to fail on cohort creation.

Could we strip whitespace from cohort names upon creation? I have seen the same error in multiple packages (this is also not specific to prediction so maybe there is another place to raise this issue?)

@jreps
Copy link
Contributor

jreps commented Mar 18, 2020

is this whitespace at the start or any whitespace? What were your cohort names? and what was the error? Looking at the code there is a part where the sql file is created using the names and a part where the sql file is loaded using the names - both of these are using other OHDSI packages (so if it is the file name that needs editing it will mean editing in each skeleton or editing in both OHDSI packages)

@rossdwilliams
Copy link
Collaborator Author

Problems with both at the beginning and at the end.

it was "ECMO w viral infection " and " ECMO" but ed has now fixed this. this could be something to fix in atlas to restrict whitespace and special characters in names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants