Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OData Client to make V4.01 requests #1999

Open
KenitoInc opened this issue Feb 15, 2021 · 1 comment · May be fixed by #2386
Open

Enable OData Client to make V4.01 requests #1999

KenitoInc opened this issue Feb 15, 2021 · 1 comment · May be fixed by #2386
Labels
feature Major release opportunity

Comments

@KenitoInc
Copy link
Contributor

OData Client seems to make V4 requests only. It would be great to allow it to make V4.01 requests, unless this will break existing logic.

A few specific areas in the code where V4 is hardcoded:

odata.net/src/Microsoft.OData.Client/DataServiceContext.cs

Line 3598 in 82eb2b2

requestVersion = Util.ODataVersion4;

odata.net/src/Microsoft.OData.Client/ALinq/ResourceBinder.cs

Line 1715 in 82eb2b2

uriVersion = Util.ODataVersion4;

odata.net/src/Microsoft.OData.Client/DataServiceRequest.cs

Line 198 in 82eb2b2

requestVersion = Util.ODataVersion4;

Assemblies affected

ODataClient 7.x

Reproduce steps

The simplest set of steps to reproduce the issue. If possible, reference a commit that demonstrates the issue.

Expected result

What would happen if there wasn't a bug.

Actual result

What is actually happening.

Additional detail

Optional, details of the root cause if known. Delete this section if you have no additional details to add.
@corranrogue9
Copy link
Contributor

odata.bind changed between 4.0 and 4.0.1

@KenitoInc KenitoInc linked a pull request Apr 28, 2022 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Major release opportunity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable v4.01 requests KenitoInc/odata.net
3 participants
@KenitoInc @corranrogue9 @Sreejithpin