Skip to content

Incorrect code generation #434

@vvdb-architecture

Description

@vvdb-architecture

Describe the bug

When processing the attached file EdmxFile.txt (a .txt file which is really an .edmx file but files with that extension can't be attached to issues) with:

odata-cli generate --metadata-uri c:\temp\EdmxFile.txt --file-name EdmxFile.cs --namespace-prefix EdmxFile --upper-camel-case --multiple-files --outputdir Output

The generated code for the container contains a lot of naming errors and duplicates, i.e.:

        /// <summary>
        /// There are no comments for Category_of_Category_used_in_Incident_(2) in the schema.
        /// </summary>
        [global::Microsoft.OData.Client.OriginalNameAttribute("Category_of_Category_used_in_Incident_(2)")]
        public virtual global::Microsoft.OData.Client.DataServiceQuerySingle<global::Edm.ComplexType> Category_of_Category_used_in_Incident_(2)(string ValidationList_RecID, global::Edm.ComplexType ValidatedFieldRef, global::Edm.ComplexType ValidatedIdFieldRef, global::Edm.ComplexType AssociatedBusinessObject)
        {
        ...
        }

... because the original names in the file are not valid C# names. There should be some kind of normalization procedure to handle this.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions