From 0e029482809b4ab9f9e53725d02825a93891a029 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?=
 <victor.martinez@tecnativa.com>
Date: Fri, 11 Oct 2024 11:51:08 +0200
Subject: [PATCH] [IMP] sign_oca: Add General settings menu item

TT41745
---
 sign_oca/__manifest__.py                          |  2 +-
 sign_oca/static/description/index.html            | 11 ++++-------
 sign_oca/views/menu.xml                           | 11 +++++++++--
 .../res_config_settings_views.xml                 | 15 +++++++++++++++
 sign_oca/views/sign_oca_field.xml                 | 13 +++++++------
 sign_oca/views/sign_oca_role.xml                  | 13 +++++++------
 6 files changed, 43 insertions(+), 22 deletions(-)
 rename sign_oca/{wizards => views}/res_config_settings_views.xml (73%)

diff --git a/sign_oca/__manifest__.py b/sign_oca/__manifest__.py
index 9c49c674..b4ad4240 100644
--- a/sign_oca/__manifest__.py
+++ b/sign_oca/__manifest__.py
@@ -14,9 +14,9 @@
         "security/security.xml",
         "views/menu.xml",
         "data/data.xml",
-        "wizards/res_config_settings_views.xml",
         "wizards/sign_oca_template_generate.xml",
         "wizards/sign_oca_template_generate_multi.xml",
+        "views/res_config_settings_views.xml",
         "views/res_partner_views.xml",
         "views/sign_oca_request_log.xml",
         "views/sign_oca_request.xml",
diff --git a/sign_oca/static/description/index.html b/sign_oca/static/description/index.html
index f82e98fa..43c66281 100644
--- a/sign_oca/static/description/index.html
+++ b/sign_oca/static/description/index.html
@@ -8,11 +8,10 @@
 
 /*
 :Author: David Goodger (goodger@python.org)
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +274,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +300,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -505,9 +504,7 @@ <h2><a class="toc-backref" href="#toc-entry-13">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-14">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
diff --git a/sign_oca/views/menu.xml b/sign_oca/views/menu.xml
index 411e2a8f..6fc13da9 100644
--- a/sign_oca/views/menu.xml
+++ b/sign_oca/views/menu.xml
@@ -11,10 +11,17 @@
         sequence="16"
         groups="sign_oca.sign_oca_group_user"
     />
-    <record model="ir.ui.menu" id="sign_oca_settings_menu">
+    <menuitem
+        name="Settings"
+        id="sign_oca_settings_menu"
+        parent="sign_oca_root_menu"
+        sequence="90"
+        groups="sign_oca.sign_oca_group_admin"
+    />
+    <!-- <record model="ir.ui.menu" id="sign_oca_settings_menu">
         <field name="name">Settings</field>
         <field name="sequence" eval="90" />
         <field name="parent_id" ref="sign_oca_root_menu" />
         <field name="groups_id" eval="[(6,0,[ref('sign_oca.sign_oca_group_admin')])]" />
-    </record>
+    </record> -->
 </odoo>
diff --git a/sign_oca/wizards/res_config_settings_views.xml b/sign_oca/views/res_config_settings_views.xml
similarity index 73%
rename from sign_oca/wizards/res_config_settings_views.xml
rename to sign_oca/views/res_config_settings_views.xml
index ac400800..8a1146ec 100644
--- a/sign_oca/wizards/res_config_settings_views.xml
+++ b/sign_oca/views/res_config_settings_views.xml
@@ -33,4 +33,19 @@
             </xpath>
         </field>
     </record>
+    <record id="sign_oca_general_settings_act_window" model="ir.actions.act_window">
+        <field name="name">General Settings</field>
+        <field name="type">ir.actions.act_window</field>
+        <field name="res_model">res.config.settings</field>
+        <field name="view_mode">form</field>
+        <field name="target">inline</field>
+        <field name="context">{'module' : 'sign_oca'}</field>
+    </record>
+    <menuitem
+        name="General settings"
+        id="sign_oca_general_settings_menu"
+        parent="sign_oca_settings_menu"
+        sequence="1"
+        action="sign_oca_general_settings_act_window"
+    />
 </odoo>
diff --git a/sign_oca/views/sign_oca_field.xml b/sign_oca/views/sign_oca_field.xml
index 2f4caa82..8bb1216c 100644
--- a/sign_oca/views/sign_oca_field.xml
+++ b/sign_oca/views/sign_oca_field.xml
@@ -46,10 +46,11 @@
         <field name="domain">[]</field>
         <field name="context">{}</field>
     </record>
-    <record model="ir.ui.menu" id="sign_oca_field_menu">
-        <field name="name">Fields</field>
-        <field name="parent_id" ref="sign_oca_settings_menu" /> <!-- TODO -->
-        <field name="action" ref="sign_oca_field_act_window" />
-        <field name="sequence" eval="16" /> <!-- TODO -->
-    </record>
+    <menuitem
+        name="Fields"
+        id="sign_oca_field_menu"
+        parent="sign_oca_settings_menu"
+        sequence="16"
+        action="sign_oca_field_act_window"
+    />
 </odoo>
diff --git a/sign_oca/views/sign_oca_role.xml b/sign_oca/views/sign_oca_role.xml
index 31f6b490..c333fff4 100644
--- a/sign_oca/views/sign_oca_role.xml
+++ b/sign_oca/views/sign_oca_role.xml
@@ -57,10 +57,11 @@
         <field name="domain">[]</field>
         <field name="context">{}</field>
     </record>
-    <record model="ir.ui.menu" id="sign_oca_role_menu">
-        <field name="name">Roles</field>
-        <field name="parent_id" ref="sign_oca_settings_menu" />
-        <field name="action" ref="sign_oca_role_act_window" />
-        <field name="sequence" eval="16" />
-    </record>
+    <menuitem
+        name="Roles"
+        id="sign_oca_role_menu"
+        parent="sign_oca_settings_menu"
+        sequence="17"
+        action="sign_oca_role_act_window"
+    />
 </odoo>