[MIG] purchase_variant_configurator: Migration to 18.0

Author: BhaveshHeliconia

purchase_variant_configurator/README.rst

@@ -103,6 +103,10 @@ Contributors
   - David Vidal
   - Ernesto Tejeda
 
+- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`__
+
+  - Bhavesh Heliconia
+
 Maintainers
 -----------
 

purchase_variant_configurator/__manifest__.py

@@ -6,7 +6,7 @@
 {
     "name": "Purchase - Product variants",
     "summary": "Product variants in purchase management",
-    "version": "16.0.2.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "depends": ["purchase", "product_variant_configurator"],
     "author": "AvanzOSC, "

purchase_variant_configurator/hooks.py

@@ -2,8 +2,10 @@
 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
 
 
-def assign_product_template(cr, registry):
+def assign_product_template(env):
     """This post-init-hook will update all existing purchase.order.line"""
+
+    cr = env.cr
     cr.execute(
         """
         UPDATE purchase_order_line AS line

purchase_variant_configurator/models/product_supplierinfo.py

@@ -7,7 +7,7 @@ class ProductSupplierinfo(models.Model):
     _inherit = "product.supplierinfo"
 
     @api.model
-    def search(self, args, offset=0, limit=None, order=None, count=False):
+    def search(self, args, offset=0, limit=None, order=None):
         """HACK: With NewId, the linked product_tmpl_id won't be a proper interger
         that we can use in a search. As we need it to get the proper pricelists
         we'll be passing it by context. The propper solution would be to
@@ -28,9 +28,5 @@ def search(self, args, offset=0, limit=None, order=None, count=False):
                         self.env.context.get("pvc_product_tmpl"),
                     )
                 args2.append(arg)
-            return super().search(
-                args2, offset=offset, limit=limit, order=order, count=count
-            )
-        return super().search(
-            args, offset=offset, limit=limit, order=order, count=count
-        )
+            return super().search(args2, offset=offset, limit=limit, order=order)
+        return super().search(args, offset=offset, limit=limit, order=order)

purchase_variant_configurator/readme/CONTRIBUTORS.md

@@ -5,3 +5,6 @@
   - Pedro M. Baeza
   - David Vidal
   - Ernesto Tejeda
+- [Heliconia Solutions Pvt. Ltd.](https://www.heliconia.io)
+  - Bhavesh Heliconia
+

purchase_variant_configurator/static/description/index.html

@@ -453,6 +453,10 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 <li>Ernesto Tejeda</li>
 </ul>
 </li>
+<li><a class="reference external" href="https://www.heliconia.io">Heliconia Solutions Pvt. Ltd.</a><ul>
+<li>Bhavesh Heliconia</li>
+</ul>
+</li>
 </ul>
 </div>
 <div class="section" id="maintainers">

purchase_variant_configurator/tests/test_purchase_order.py

@@ -1,7 +1,7 @@
 # Copyright 2016 ACSONE SA/NV
 # Copyright 2024 Tecnativa - Víctor Martínez
 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html
-from odoo.tests import Form
+from odoo import Command
 
 from odoo.addons.base.tests.common import BaseCommon
 
@@ -51,12 +51,10 @@ def setUpClass(cls):
                 "categ_id": cls.category1.id,
                 "standard_price": 100,
                 "attribute_line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "attribute_id": cls.attribute1.id,
-                            "value_ids": [(6, 0, [cls.value1.id, cls.value2.id])],
+                            "value_ids": [Command.set([cls.value1.id, cls.value2.id])],
                         },
                     )
                 ],
@@ -112,62 +110,6 @@ def test_onchange_product_tmpl_id_01(self):
             f"{self.product_template_no.name}\n{self.product_template_no.description_purchase}",
         )
 
-    def test_onchange_product_tmpl_id_02(self):
-        order_form = Form(self.env["purchase.order"])
-        order_form.partner_id = self.supplier
-        with order_form.order_line.new() as line_form:
-            line_form.product_tmpl_id = self.product_template_yes
-        order = order_form.save()
-        line = order.order_line
-        self.assertFalse(line.product_id)
-        self.assertIn("Product template 1", line.name)
-        self.assertIn("Purchase Description", line.name)
-        self.assertEqual(line.product_uom, self.product_template_yes.uom_id)
-        self.assertEqual(line.price_unit, 90)
-        self.assertEqual(line.product_qty, 11)
-        self.assertTrue(line.date_planned)
-        order.button_confirm()
-        self.assertTrue(line.product_id)
-        self.assertIn("Product template 1", line.name)
-        self.assertIn("Purchase Description", line.name)
-
-    def test_onchange_product_attribute_ids(self):
-        product = self.product_product.create(
-            {
-                "name": "Test product 01",
-                "product_tmpl_id": self.product_template_yes.id,
-                "product_attribute_ids": [
-                    (
-                        0,
-                        0,
-                        {
-                            "product_tmpl_id": self.product_template_yes.id,
-                            "attribute_id": self.attribute1.id,
-                            "value_id": self.value1.id,
-                        },
-                    )
-                ],
-            }
-        )
-        order_form = Form(self.env["purchase.order"])
-        order_form.partner_id = self.supplier
-        with order_form.order_line.new() as line_form:
-            line_form.product_tmpl_id = self.product_template_yes
-            with line_form.product_attribute_ids.edit(0) as pa_form:
-                pa_form.value_id = self.value1
-        order = order_form.save()
-        line = order.order_line
-        self.assertEqual(line.product_id, product)
-        expected_domain = [
-            ("product_tmpl_id", "=", self.product_template_yes.id),
-            (
-                "product_template_attribute_value_ids",
-                "=",
-                product.product_template_attribute_value_ids[0].id,
-            ),
-        ]
-        self.assertEqual(line.product_id_configurator_domain, expected_domain)
-
     def test_can_create_product_variant(self):
         line = self.purchase_order_line.new(
             {
@@ -197,33 +139,6 @@ def test_can_create_product_variant(self):
         self.assertTrue(line.product_id)
         self.assertFalse(line.create_product_variant)
 
-    def test_onchange_product_id(self):
-        product = self.product_product.create(
-            {
-                "name": "Test product 02",
-                "product_tmpl_id": self.product_template_yes.id,
-                "product_attribute_ids": [
-                    (
-                        0,
-                        0,
-                        {
-                            "product_tmpl_id": self.product_template_yes.id,
-                            "attribute_id": self.attribute1.id,
-                            "value_id": self.value1.id,
-                        },
-                    )
-                ],
-            }
-        )
-        order_form = Form(self.env["purchase.order"])
-        order_form.partner_id = self.supplier
-        with order_form.order_line.new() as line_form:
-            line_form.product_id = product
-        order = order_form.save()
-        line = order.order_line
-        self.assertEqual(len(line.product_attribute_ids), 1)
-        self.assertEqual(line.product_tmpl_id, self.product_template_yes)
-
     def test_button_confirm_01(self):
         order = self.purchase_order.create({"partner_id": self.supplier.id})
         line_1 = self.purchase_order_line.new(
@@ -235,9 +150,7 @@ def test_button_confirm_01(self):
                 "date_planned": "2016-01-01",
                 "product_uom": self.product_template_yes.uom_id.id,
                 "product_attribute_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "product_tmpl_id": self.product_template_yes.id,
                             "attribute_id": self.attribute1.id,
@@ -282,37 +195,48 @@ def test_button_confirm_01(self):
             "All purchase lines must have a product",
         )
 
-    def test_button_confirm_02(self):
-        order_form = Form(self.env["purchase.order"])
-        order_form.partner_id = self.supplier
-        with order_form.order_line.new() as line_form:
-            line_form.product_tmpl_id = self.product_template_yes
-            with line_form.product_attribute_ids.edit(0) as pa_form:
-                pa_form.value_id = self.value1
-        order = order_form.save()
-        line1 = order.order_line
-        self.assertFalse(line1.product_id)
-        order.button_confirm()
-        self.assertTrue(line1.product_id)
-        purchase = Form(order)
-        with purchase.order_line.new() as line_form:
-            line_form.product_tmpl_id = self.product_template_yes
-            with line_form.product_attribute_ids.edit(0) as pa_form:
-                pa_form.value_id = self.value2
-        purchase.save()
-        line2 = order.order_line - line1
-        self.assertTrue(line2.product_id)
-        self.assertNotEqual(line1.product_id, line2.product_id)
+    def test_compute_product_id_is_required(self):
+        # Set the company configuration to True
+        self.env.company.po_confirm_create_variant = True
+        line = self.purchase_order_line.new(
+            {
+                "product_tmpl_id": self.product_template_yes.id,
+                "product_uom": self.product_template_yes.uom_id.id,
+                "product_qty": 5,
+                "company_id": self.env.company.id,  # Explicitly set the company
+            }
+        )
+        line._compute_product_id_is_required()
+        self.assertFalse(
+            line.product_id_is_required,
+            "Product ID should not be required when po_confirm_create_variant is True.",
+        )
+
+        # Set the company configuration to False
+        self.env.company.po_confirm_create_variant = False
+        line._compute_product_id_is_required()
+        self.assertTrue(
+            line.product_id_is_required,
+            "Product ID should be required when po_confirm_create_variant is False.",
+        )
+
+    def test_create_purchase_order_line_with_variant_creation(self):
+        # Create a purchase order in 'purchase' state
+        order = self.purchase_order.create({"partner_id": self.supplier.id})
+        order.button_confirm()  # Move the order to 'purchase' state
 
-    def test_copy(self):
-        old_date = "2017-01-01"
-        order_form = Form(self.env["purchase.order"])
-        order_form.partner_id = self.supplier
-        with order_form.order_line.new() as line_form:
-            line_form.product_tmpl_id = self.product_template_yes
-            line_form.date_planned = old_date
-            with line_form.product_attribute_ids.edit(0) as pa_form:
-                pa_form.value_id = self.value1
-        order = order_form.save()
-        new_order = order.copy()
-        self.assertNotEqual(new_order.order_line.date_planned, old_date)
+        # Create a line without a product but with a product template
+        line_vals = {
+            "order_id": order.id,
+            "product_tmpl_id": self.product_template_yes.id,
+            "product_uom": self.product_template_yes.uom_id.id,
+            "product_qty": 1,
+            "name": "Line with variant creation",
+            "date_planned": "2024-01-01",
+        }
+        line = self.purchase_order_line.create([line_vals])
+
+        # Ensure a product was created
+        self.assertTrue(
+            line.product_id, "Product variant should be created for the line."
+        )

purchase_variant_configurator/views/inherited_purchase_order_views.xml

@@ -6,7 +6,7 @@
         <field name="inherit_id" ref="purchase.purchase_order_form" />
         <field name="priority" eval="20" />
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='order_line']/tree" position="attributes">
+            <xpath expr="//field[@name='order_line']/list" position="attributes">
                 <!-- force using the form -->
                 <attribute name="editable" />
             </xpath>
@@ -28,9 +28,9 @@
                         nolabel="1"
                         colspan="2"
                     >
-                        <tree create="0" delete="0" editable="1">
-                            <field name="owner_model" invisible="1" />
-                            <field name="owner_id" invisible="1" />
+                        <list create="0" delete="0" editable="bottom">
+                            <!--                            <field name="owner_model" invisible="1" />-->
+                            <!--                            <field name="owner_id" invisible="1" />-->
                             <field name="attribute_id" force_save="1" />
                             <field
                                 name="possible_value_ids"
@@ -42,7 +42,7 @@
                                 name="value_id"
                                 context="{'show_attribute': False, 'default_attribute_id': attribute_id, 'template_for_attribute_value': product_tmpl_id}"
                             />
-                        </tree>
+                        </list>
                     </field>
                     <field name="can_create_product" invisible="1" />
                     <field
@@ -76,7 +76,7 @@
                 <field name="product_id_configurator_domain" invisible="1" />
             </xpath>
             <xpath
-                expr="//field[@name='order_line']/tree//field[@name='product_id']"
+                expr="//field[@name='order_line']/list//field[@name='product_id']"
                 position="before"
             >
                 <field
@@ -85,14 +85,14 @@
                 />
             </xpath>
             <xpath
-                expr="//field[@name='order_line']/tree//field[@name='product_id']"
+                expr="//field[@name='order_line']/list//field[@name='product_id']"
                 position="after"
             >
                 <field name="product_id_configurator_domain" invisible="1" />
                 <field name="product_id_is_required" invisible="1" />
             </xpath>
             <xpath
-                expr="//field[@name='order_line']/tree//field[@name='product_id']"
+                expr="//field[@name='order_line']/list//field[@name='product_id']"
                 position="attributes"
             >
                 <attribute name="domain">product_id_configurator_domain</attribute>

purchase_variant_configurator/views/res_config_settings_views.xml

@@ -7,7 +7,7 @@
             ref="purchase.res_config_settings_view_form_purchase"
         />
         <field name="arch" type="xml">
-            <xpath expr="//div[@data-key='purchase']" position="inside">
+            <xpath expr="//app[@name='purchase']" position="inside">
                 <h2>Product configurator</h2>
                 <div
                     class="row mt16 o_settings_container"