Fix add tests

Author: bosd

partner_identification_automation_activity/tests/test_identification_activity.py

@@ -3460,3 +3460,181 @@ def test_write_method_status_change_triggers_activity_creation(self):
         )
 
         self.assertTrue(activity.exists())
+
+    def test_create_method_fallback_no_responsible_user(self):
+        """Test create method fallback when no responsible user is set"""
+        # Create category with initial activity but no responsible user
+        category_no_user = self.env["res.partner.id_category"].create(
+            {
+                "code": "no_user",
+                "name": "No User Category",
+                "create_activity_on_new": True,
+                "initial_activity_type_id": self.env.ref(
+                    "mail.mail_activity_data_todo"
+                ).id,
+                # No responsible_user_id set
+            }
+        )
+
+        # Create identification with no responsible user in category
+        identification = self.env["res.partner.id_number"].create(
+            {
+                "partner_id": self.test_partner.id,
+                "category_id": category_no_user.id,
+                "name": "TEST_NO_USER",
+                "status": "draft",
+            }
+        )
+
+        # Activity should be assigned to current user as fallback
+        activity = self.env["mail.activity"].search(
+            [
+                ("res_model", "=", "res.partner.id_number"),
+                ("res_id", "=", identification.id),
+            ],
+            limit=1,
+        )
+
+        self.assertTrue(activity.exists())
+        # Should fall back to current user when no responsible user is set
+        self.assertEqual(activity.user_id, self.env.user)
+
+    def test_renewal_activities_fallback_no_responsible_user(self):
+        """Test _create_renewal_activities fallback when no responsible user is set"""
+        # Create category with renewal settings but no responsible user
+        category_no_user = self.env["res.partner.id_category"].create(
+            {
+                "code": "no_user_renew",
+                "name": "No User Renew Category",
+                "renewal_lead_number": 5,
+                "renewal_lead_unit": "days",
+                # No responsible_user_id set
+            }
+        )
+
+        # Create identification
+        identification = self.env["res.partner.id_number"].create(
+            {
+                "partner_id": self.test_partner.id,
+                "category_id": category_no_user.id,
+                "name": "TEST_NO_USER_RENEW",
+                "status": "draft",
+                "valid_until": "2023-12-31",
+            }
+        )
+
+        # Change status to pending to trigger renewal activity
+        identification.write({"status": "pending"})
+
+        # Check that activity was created and assigned to current user
+        activity = self.env["mail.activity"].search(
+            [
+                ("res_model", "=", "res.partner.id_number"),
+                ("res_id", "=", identification.id),
+            ],
+            limit=1,
+        )
+
+        self.assertTrue(activity.exists())
+        # Should fall back to current user when no responsible user is set
+        self.assertEqual(activity.user_id, self.env.user)
+
+    def test_renewal_activities_no_valid_until_date(self):
+        """Test _create_renewal_activities with no valid_until date (edge case)"""
+        # Create identification without valid_until date
+        identification = self.env["res.partner.id_number"].create(
+            {
+                "partner_id": self.test_partner.id,
+                "category_id": self.category.id,
+                "name": "TEST_NO_EXPIRY_DATE",
+                "status": "draft",
+                # No valid_until date
+            }
+        )
+
+        # Call _create_renewal_activities directly - should handle missing expiry
+        # This should not raise an error
+        try:
+            identification._create_renewal_activities()
+            success = True
+        except Exception:
+            success = False
+
+        self.assertTrue(success)
+
+    def test_write_method_with_status_not_in_vals(self):
+        """Test write method when status is not in the vals dictionary"""
+        # Create identification
+        identification = self.env["res.partner.id_number"].create(
+            {
+                "partner_id": self.test_partner.id,
+                "category_id": self.category.id,
+                "name": "TEST_NO_STATUS_WRITE",
+                "status": "draft",
+            }
+        )
+
+        # Update a field other than status - should not trigger activity creation
+        identification.write({"name": "UPDATED_NAME_NO_ACTIVITY"})
+
+        # No activity should be created since status didn't change to 'pending'
+        activities = self.env["mail.activity"].search(
+            [
+                ("res_model", "=", "res.partner.id_number"),
+                ("res_id", "=", identification.id),
+            ]
+        )
+        self.assertEqual(len(activities), 0)
+
+    def test_create_method_with_summary_containing_record_name(self):
+        """Test create method handles summary that already contains record name"""
+        # Create custom activity type with summary that includes placeholder
+        custom_activity_type = self.env["mail.activity.type"].create(
+            {
+                "name": "Custom Summary",
+                "summary": "Initial check: TEST_NO_EXPIRY_DATE",  # Same name as record
+            }
+        )
+
+        self.category.write(
+            {
+                "create_activity_on_new": True,
+                "initial_activity_type_id": custom_activity_type.id,
+            }
+        )
+
+        # Create identification - the summary should not be duplicated
+        identification = self.env["res.partner.id_number"].create(
+            {
+                "partner_id": self.test_partner.id,
+                "category_id": self.category.id,
+                "name": "TEST_NO_EXPIRY_DATE",  # Same name as in activity summary
+                "status": "draft",
+            }
+        )
+
+        # Check that the activity summary doesn't have duplicate name
+        activity = self.env["mail.activity"].search(
+            [
+                ("res_model", "=", "res.partner.id_number"),
+                ("res_id", "=", identification.id),
+            ],
+            limit=1,
+        )
+
+        self.assertTrue(activity.exists())
+        # Summary should contain the name, but not duplicate it
+        self.assertIn("TEST_NO_EXPIRY_DATE", activity.summary)
+
+    def test_renewal_activities_with_nonexistent_activity_type(self):
+        """Test _create_renewal_activities handles nonexistent activity type"""
+        # Create custom activity type and then delete it (to make it nonexistent)
+        temp_activity_type = self.env["mail.activity.type"].create(
+            {
+                "name": "Temp Activity Type",
+            }
+        )
+        temp_activity_type_id = temp_activity_type.id
+        temp_activity_type.unlink()  # Now it doesn't exist
+
+        # Create category with the now-deleted activity type