Skip to content

Commit db24450

Browse files
committed
[ingest-server-grpc] return stamp to GetResponse and ListResponse
1 parent 48a2703 commit db24450

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

direct/ingest-server/src/main/java/cz/o2/proxima/direct/server/RetrieveService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,8 @@ public void listAttributes(
160160
response.addValue(
161161
ListResponse.AttrValue.newBuilder()
162162
.setAttribute(kv.getAttribute())
163-
.setValue(ByteString.copyFrom(kv.getValue()))));
163+
.setValue(ByteString.copyFrom(kv.getValue()))
164+
.setStamp(kv.getStamp())));
164165
noticeListResult(request, entity, wildcard, kvs);
165166
replyLogged(responseObserver, request, response.build());
166167
} catch (Status s) {
@@ -297,6 +298,7 @@ public void get(Rpc.GetRequest request, StreamObserver<Rpc.GetResponse> response
297298
Rpc.GetResponse.newBuilder()
298299
.setStatus(200)
299300
.setValue(ByteString.copyFrom(kv.getValue()))
301+
.setStamp(kv.getStamp())
300302
.build());
301303
}
302304
} catch (Status s) {

direct/ingest-server/src/test/java/cz/o2/proxima/direct/server/RetrieveServiceTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,6 +1091,7 @@ public void testGetValidExtendedScheme() throws InvalidProtocolBufferException {
10911091
String key = "my-fancy-entity-key";
10921092
ExtendedMessage payload = ExtendedMessage.newBuilder().setFirst(1).setSecond(2).build();
10931093

1094+
long now = System.currentTimeMillis();
10941095
Optionals.get(server.direct.getWriter(attribute))
10951096
.write(
10961097
StreamElement.upsert(
@@ -1099,7 +1100,7 @@ public void testGetValidExtendedScheme() throws InvalidProtocolBufferException {
10991100
UUID.randomUUID().toString(),
11001101
key,
11011102
attribute.getName(),
1102-
System.currentTimeMillis(),
1103+
now,
11031104
payload.toByteArray()),
11041105
CommitCallback.noop());
11051106
Rpc.GetRequest request =
@@ -1140,6 +1141,7 @@ public void onCompleted() {
11401141
200,
11411142
response.getStatus());
11421143
assertEquals(payload, ExtendedMessage.parseFrom(response.getValue().toByteArray()));
1144+
assertEquals(now, response.getStamp());
11431145
}
11441146

11451147
@Test
@@ -1192,14 +1194,15 @@ public void testListWithLongPrefix() {
11921194
String key = "my-fancy-entity-key";
11931195

11941196
OnlineAttributeWriter writer = Optionals.get(server.direct.getWriter(attribute));
1197+
long now = System.currentTimeMillis();
11951198
writer.write(
11961199
StreamElement.upsert(
11971200
entity,
11981201
attribute,
11991202
UUID.randomUUID().toString(),
12001203
key,
12011204
attribute.toAttributePrefix() + "non-prefix",
1202-
System.currentTimeMillis(),
1205+
now,
12031206
new byte[] {}),
12041207
CommitCallback.noop());
12051208
writer.write(
@@ -1209,7 +1212,7 @@ public void testListWithLongPrefix() {
12091212
UUID.randomUUID().toString(),
12101213
key,
12111214
attribute.toAttributePrefix() + "prefix",
1212-
System.currentTimeMillis(),
1215+
now,
12131216
new byte[] {}),
12141217
CommitCallback.noop());
12151218

rpc/src/main/proto/rpc.proto

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,11 @@ message GetResponse {
197197
**/
198198
bytes value = 3;
199199

200+
/**
201+
* Timestamp in ms.
202+
**/
203+
uint64 stamp = 4;
204+
200205
}
201206

202207
/**
@@ -241,6 +246,9 @@ message ListResponse {
241246
/** The value of the attribute. */
242247
bytes value = 2;
243248

249+
/** Timestamp */
250+
uint64 stamp = 3;
251+
244252
}
245253

246254
/**

0 commit comments

Comments
 (0)