Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs old version (0.26.0) by default #62

Open
Bouke opened this issue Jan 25, 2021 · 3 comments
Open

Installs old version (0.26.0) by default #62

Bouke opened this issue Jan 25, 2021 · 3 comments

Comments

@Bouke
Copy link

Bouke commented Jan 25, 2021

This task installs version 0.26.0 when the latest version (0.34.0 at the moment) is expected. This is because queryLatestMatch fetches https://api.nuget.org/v3/registration3/nukeeper/index.json, which only lists 0.26.0 as the latest release (possibly due to pagination?):

let nukeeperVersionEndpoint = "https://api.nuget.org/v3/registration3/nukeeper/index.json";
.

I think the code should be changed to query https://api.nuget.org/v3-flatcontainer/nukeeper/index.json, listing all versions, and then fetch the matching package by querying https://api.nuget.org/v3/registration5-semver1/nukeeper/{version}.json.

Relevant part of the logs:

##[debug]version=0.*
##[debug]checkLatest=true
##[debug]isExplicit: null
##[debug]explicit? false
##[debug]isExplicit: null
##[debug]explicit? false
##[debug]evaluating 54 versions
##[debug]matched: 0.26.0
##[debug]isExplicit: 0.26.0
##[debug]explicit? true
##[debug]Agent.Version=2.181.0
##[debug]Agent.TempDirectory=D:\a\_temp
##[debug]testing directory 'D:\a\_temp'
Downloading: https://api.nuget.org/v3-flatcontainer/nukeeper/0.26.0/nukeeper.0.26.0.nupkg
@CrispyDrone
Copy link

CrispyDrone commented Mar 9, 2021

It seems from NuGet's documentation, it should hard code the type of a resource which is RegistrationsBaseUrl in our case.

Clients are expected to hard code the @type values that they understand and look them up in a package source's service index. The exact @type values in use today are enumerated on the individual resource reference documents listed in the API overview.

I think this url that's hard coded right now, is an old url. Why exactly it doesn't list the newer versions, I'm not sure. The current versions look semver1 compatible (so not semver2). See NuGet/Home#7869 (comment)

@MartinDemberger
Copy link

@MartinDemberger
Copy link

As a work arround you can specify the version.

- task: NuKeeper@0
    inputs:
      version: 0.34.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants