Rebased PR based on latest master - (Feature) Lazy-Images-Full with local dependencies. (Fix) Replace KY with OFetch. (Fix) Cleaned up unnceccesary and erroneous changes

Author: mustaqimarifin

examples/full/components/NotionPage.tsx

@@ -1,6 +1,6 @@
 import dynamic from 'next/dynamic'
 import Head from 'next/head'
-//import Image from 'next/image'
+// import Image from 'next/image'
 import Link from 'next/link'
 import { useRouter } from 'next/router'
 import { type ExtendedRecordMap } from 'notion-types'
@@ -182,7 +182,7 @@ export function NotionPage({
         previewImages={previewImagesEnabled}
         components={{
           // NOTE (transitive-bullshit 3/12/2023): I'm disabling next/image for this repo for now because the amount of traffic started costing me hundreds of dollars a month in Vercel image optimization costs. I'll probably re-enable it in the future if I can find a better solution.
-          //nextImage: Image,
+          // nextLegacyImage: Image,
           nextLink: Link,
           Code,
           Collection,

examples/full/lib/notion.ts

@@ -30,6 +30,7 @@ export async function getPage(pageId: string): Promise<ExtendedRecordMap> {
 
   return recordMap
 }
+
 export async function search(params: SearchParams): Promise<SearchResults> {
   if ('search' in notion) {
     return notion.search(params)

examples/full/next.config.js

@@ -1,22 +1,14 @@
-/** @type {import('next').NextConfig} */
-const nextConfig = {
-  eslint: {
-    ignoreDuringBuilds: true
-  },
-  typescript: {
-    ignoreBuildErrors: true
-  },
+export default {
+  staticPageGenerationTimeout: 300,
   images: {
-    remotePatterns: [
-      { protocol: 'https', hostname: 'www.notion.so' },
-      { protocol: 'https', hostname: 'notion.so' },
-      { protocol: 'https', hostname: 'images.unsplash.com' },
-      { protocol: 'https', hostname: 'abs.twimg.com' },
-      { protocol: 'https', hostname: 'pbs.twimg.com' },
-      { protocol: 'https', hostname: 's3.us-west-2.amazonaws.com' }
+    domains: [
+      'www.notion.so',
+      'notion.so',
+      'images.unsplash.com',
+      'abs.twimg.com',
+      'pbs.twimg.com',
+      's3.us-west-2.amazonaws.com'
     ],
     formats: ['image/avif', 'image/webp']
   }
 }
-
-export default nextConfig

examples/minimal/next.config.js

@@ -1,4 +1,4 @@
-const nextConfig = {
+export default {
   staticPageGenerationTimeout: 300,
   images: {
     domains: [
@@ -10,5 +10,3 @@ const nextConfig = {
     formats: ['image/avif', 'image/webp']
   }
 }
-
-export default nextConfig

package.json

@@ -16,7 +16,7 @@
     "dev": "turbo dev --concurrency 50 --continue --filter='./packages/*'",
     "clean": "turbo clean",
     "test": "turbo test",
-    "test:format": "prettier --check \"**/*.{js,ts,tsx}\" --write",
+    "test:format": "prettier --check \"**/*.{js,ts,tsx}\"",
     "test:lint": "turbo test:lint",
     "test:typecheck": "turbo test:typecheck",
     "test:unit": "turbo test:unit",
@@ -53,4 +53,4 @@
       "eslint --fix"
     ]
   }
-}
+}

packages/notion-client/package.json

@@ -22,12 +22,12 @@
     "watch": "tsup --watch --silent --onSuccess 'echo build successful'",
     "clean": "del build",
     "test": "run-s test:*",
-    "test:lint": "eslint . --fix",
+    "test:lint": "eslint .",
     "test:typecheck": "tsc --noEmit",
     "test:unit": "vitest run"
   },
   "dependencies": {
-    "got": "catalog:",
+    "ofetch": "catalog:",
     "notion-types": "workspace:*",
     "notion-utils": "workspace:*",
     "p-map": "catalog:"