Merge pull request #104 from NosCoreIO/betterNaming

Fix culture

Author: erwan-joly

src/NosCore.Shared/I18N/I18NTestHelpers.cs

@@ -22,9 +22,9 @@ public static IEnumerable<T> GetKeysWithMissingTranslations<T>(ILogLanguageLocal
 
         public static IEnumerable<string> GetUselessTranslations(ILogLanguageLocalizer localizer, List<string> keys)
         {
-            return localizer.GetAllStrings(false)
+            return localizer.GetAllStrings()
                 .Where(resourceKey => !keys.Contains(resourceKey.Name))
-                .Select(translation => translation.Value);
+                .Select(translation => translation.Name);
         }
 
         public static IEnumerable<T> GetUselessLanguageKeys<T>()

src/NosCore.Shared/I18N/ILogLanguageLocalizer.cs

@@ -18,5 +18,5 @@ public interface ILogLanguageLocalizer<T> : ILogLanguageLocalizer where T : stru
 
 public interface ILogLanguageLocalizer
 {
-    IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures);
+    IEnumerable<LocalizedString> GetAllStrings();
 }

src/NosCore.Shared/I18N/LogLanguageLocalizer.cs

@@ -6,7 +6,9 @@
 
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using Microsoft.Extensions.Localization;
+using NosCore.Shared.Enumerations;
 
 namespace NosCore.Shared.I18N
 {
@@ -37,7 +39,7 @@ public LocalizedString this[T key]
             }
         }
 
-        public IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures) =>
-            _stringLocalizer.GetAllStrings(includeParentCultures);
+        public IEnumerable<LocalizedString> GetAllStrings() =>
+            _stringLocalizer.GetAllStrings(CultureInfo.CurrentUICulture.Equals(new CultureInfo(RegionType.EN.ToString())));
     }
 }

src/NosCore.Shared/NosCore.Shared.csproj

@@ -12,7 +12,7 @@
     <RepositoryUrl>https://github.com/NosCoreIO/NosCore.Dao.git</RepositoryUrl>
     <PackageIconUrl></PackageIconUrl>
     <PackageTags>nostale, noscore, nostale private server source, nostale emulator</PackageTags>
-    <Version>3.3.0</Version>
+    <Version>3.4.0</Version>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <Description>NosCore's Shared Components</Description>
     <PackageLicenseExpression></PackageLicenseExpression>