Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation breaking on admin edit page #556

Open
adring93 opened this issue Mar 19, 2025 · 1 comment · Fixed by #559 · May be fixed by #577
Open

Fix navigation breaking on admin edit page #556

adring93 opened this issue Mar 19, 2025 · 1 comment · Fixed by #559 · May be fixed by #577
Assignees
Labels
bug Something isn't working

Comments

@adring93
Copy link
Contributor

User Story

As an admin, I want the navigation on the Admin Edit page to work without breaking, so I can use the site smoothly across all screen sizes.

Acceptance Criteria

  • Fix the navigation breaking issue on "edit-profile-admin.html" at medium screen sizes (around 768px), ensuring no overlap or site breakage.
  • Use Tailwind CSS to adjust the navigation layout, maintaining consistency with the overall page design on all screen sizes (desktop, tablet, mobile).
  • Ensure the navigation fix integrates with the existing page layout set by other tasks (e.g., Fix Admin Edit page for all screen sizes #416).
  • Do not use JavaScript for this task unless explicitly approved by the teacher, rely on HTML and CSS only.

Technical Notes

  • Use Tailwind utility classes for layout adjustments (e.g., w-full, max-w-full to prevent overflow).
  • Test on Live Server across devices, confirming the navigation works without breaking per Figma mockups.
  • Verify accessibility with keyboard navigation (e.g., tab focus visible).
@adring93 adring93 assigned adring93 and Martine04384 and unassigned adring93 Mar 19, 2025
@inastefansdottir inastefansdottir added the bug Something isn't working label Mar 19, 2025
@Martine04384 Martine04384 linked a pull request Mar 19, 2025 that will close this issue
@inastefansdottir
Copy link
Contributor

Just noticed after accepting the PR that the logo needs to be changed, and the dashboard > profile needs less space around it. Totally my fault for catching it so late!

Left picture is how it looks on live server and the right is from the figma file.

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants