Merge pull request #1067 from NordicSemiconductor/update_big_dependencies

Update big dependencies

Author: datenreisender

Changelog.md

@@ -3,10 +3,10 @@
 This project provides shared commodities for developing nRF Connect for Desktop
 apps and their launcher:
 
--   React components
--   Build scripts
--   Configurations
--   Test facilities
+- React components
+- Build scripts
+- Configurations
+- Test facilities
 
 ## Developing a new feature or fixing an error
 
@@ -21,10 +21,10 @@ change as a new version right ahead, add a new section with the heading
 
 To release, two files must be up-to-date:
 
--   `package.json` contain the correct version number (one more than the last
-    release).
--   `Changelog.md` must contain an entry, with that version number and today's
-    date.
+- `package.json` contain the correct version number (one more than the last
+  release).
+- `Changelog.md` must contain an entry, with that version number and today's
+  date.
 
 By running `npm run prepare-shared-release` you update the version in
 `package.json` and in `Changelog.md` a potential `## Unreleased` heading is

README.md

@@ -37,7 +37,7 @@ paletteColorsKeys.forEach(color => {
 });
 
 const colors = Object.entries(flattenedColors).filter(
-    ([key]) => !paletteColorsKeys.find(c => key.startsWith(c))
+    ([key]) => !paletteColorsKeys.find(c => key.startsWith(c)),
 );
 
 module.exports = {

config/colors.js

@@ -17,9 +17,10 @@ module.exports = {
     extends: [
         'eslint:recommended',
         'airbnb',
-        'plugin:@typescript-eslint/recommended',
+        'plugin:@typescript-eslint/strict',
         'plugin:import/recommended',
         'plugin:import/typescript',
+        'plugin:jsonc/recommended-with-jsonc',
         'prettier',
     ],
     ignorePatterns: [
@@ -35,9 +36,7 @@ module.exports = {
             'error',
             { 'ts-expect-error': 'allow-with-description' },
         ],
-        '@typescript-eslint/no-empty-function': 'off',
         '@typescript-eslint/no-shadow': 'error',
-        '@typescript-eslint/no-var-requires': 'off',
         'import/default': 'error',
         'import/extensions': 'off',
         'import/named': 'error',
@@ -64,10 +63,11 @@ module.exports = {
                 plugins: [
                     'preset-lint-markdown-style-guide',
                     'frontmatter',
-                    ['lint-no-duplicate-headings', false],
-                    ['lint-list-item-indent', false],
                     ['lint-emphasis-marker', false],
+                    ['lint-list-item-content-indent', false],
+                    ['lint-list-item-indent', false],
                     ['lint-list-item-spacing', false],
+                    ['lint-no-duplicate-headings', false],
                     ['lint-no-literal-urls', false],
                 ],
             },
@@ -125,6 +125,10 @@ module.exports = {
             },
         ],
         'valid-jsdoc': ['error', { prefer: { return: 'returns' } }],
+        'no-empty-function': [
+            'error',
+            { allow: ['arrowFunctions', 'constructors'] },
+        ],
     },
     overrides: [
         {
@@ -158,10 +162,17 @@ module.exports = {
         },
         {
             files: ['*.json'],
+            parser: 'jsonc-eslint-parser',
             rules: {
                 'no-template-curly-in-string': 'off',
             },
         },
+        {
+            files: ['*.js'],
+            rules: {
+                '@typescript-eslint/no-require-imports': 'off',
+            },
+        },
         {
             files: [
                 '**/__tests__/**/*.[jt]s?(x)',

config/eslintrc.js

@@ -18,7 +18,7 @@ module.exports = (disabledMocks = []) => ({
         '^electron-store$': `${mockDir}/electronStoreMock.ts`,
         '@electron/remote': `${mockDir}/remoteMock.ts`,
         'react-markdown': require.resolve(
-            'react-markdown/react-markdown.min.js'
+            'react-markdown/react-markdown.min.js',
         ),
         ...(disabledMocks.includes('packageJson')
             ? {}

config/jest.config.js

@@ -49,7 +49,7 @@ export interface AppInfo {
 export const semver = z.string().regex(
     // From https://semver.org
     /^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$/,
-    'Is not a valid string for a semantic version'
+    'Is not a valid string for a semantic version',
 );
 
 const nrfutilModuleName = z.string();
@@ -60,7 +60,7 @@ export type NrfutilModuleVersion = z.infer<typeof nrfutilModuleVersion>;
 
 export const nrfModules = z.record(
     nrfutilModuleName,
-    z.tuple([nrfutilModuleVersion])
+    z.tuple([nrfutilModuleVersion]),
 );
 
 export type NrfutilModules = z.infer<typeof nrfModules>;

ipc/MetaFiles.ts

@@ -16,28 +16,28 @@ launcher will react in the way the apps expect it.
 
 There are a few conventions we follow with the code here in `ipc/`:
 
--   In each file there are pairs of functions: One to send a message over an IPC
-    channel (e.g. `openApp`) and another to register a handler for the messages
-    on that same channel (e.g. `registerOpenApp`).
+- In each file there are pairs of functions: One to send a message over an IPC
+  channel (e.g. `openApp`) and another to register a handler for the messages on
+  that same channel (e.g. `registerOpenApp`).
 
     Usually these two functions utilize a shared signature which is defined in a
     type above them. Usually the functions are defined by invoking functions
     from `infrastructure/mainToRenderer.ts` or
     `infrastructure/rendererToMain.ts` which also use that type.
 
--   The functions mentioned before are then exported in objects with the names
-    `inMain`, `forRenderer`, `inRenderer`, and `forMain` to signify how the
-    functions are supposed to be used. E.g. the mentioned `openApp` is in
-    `inMain` because it is called by code in the renderer processes to invoke
-    code in the main process to open an window. `registerOpenApp` is in
-    `forRenderer` because the handler is registered so that code in the renderer
-    processes can invoke it.
+- The functions mentioned before are then exported in objects with the names
+  `inMain`, `forRenderer`, `inRenderer`, and `forMain` to signify how the
+  functions are supposed to be used. E.g. the mentioned `openApp` is in `inMain`
+  because it is called by code in the renderer processes to invoke code in the
+  main process to open an window. `registerOpenApp` is in `forRenderer` because
+  the handler is registered so that code in the renderer processes can invoke
+  it.
 
     So, `inMain` and `forRenderer` are used when sending messages from the
     renderer processes to the main process. `inRenderer` and `forMain` are used,
     when sending messages from the main process to the renderer processes.
 
--   The code here in `ipc/` must neither reference any code in `src/` (which is
-    for code of the renderer processes) nor in `main/` (which is for code in the
-    main process). Only the other way around code in those two folders can
-    reference code in `ipc/`.
+- The code here in `ipc/` must neither reference any code in `src/` (which is
+  for code of the renderer processes) nor in `main/` (which is for code in the
+  main process). Only the other way around code in those two folders can
+  reference code in `ipc/`.

ipc/README.md

@@ -30,7 +30,7 @@ type GetAppDetails = () => AppDetailsFromLauncher;
 const getAppDetails = invoke<GetAppDetails>(channel.request);
 
 const registerGetAppDetails = (
-    onGetAppDetails: (webContents: WebContents) => AppDetailsFromLauncher
+    onGetAppDetails: (webContents: WebContents) => AppDetailsFromLauncher,
 ) => {
     handleWithSender<GetAppDetails>(channel.request)(onGetAppDetails);
 

ipc/appDetails.ts

@@ -119,23 +119,23 @@ export type GetDownloadableAppsResult = {
 type GetDownloadableApps = () => GetDownloadableAppsResult;
 
 const getDownloadableApps = invoke<GetDownloadableApps>(
-    channel.getDownloadableApps
+    channel.getDownloadableApps,
 );
 const registerGetDownloadableApps = handle<GetDownloadableApps>(
-    channel.getDownloadableApps
+    channel.getDownloadableApps,
 );
 
 // installDownloadableApp
 type InstallDownloadableApp = (
     app: DownloadableApp,
-    version?: string
+    version?: string,
 ) => DownloadableApp;
 
 const installDownloadableApp = invoke<InstallDownloadableApp>(
-    channel.installDownloadableApp
+    channel.installDownloadableApp,
 );
 const registerInstallDownloadableApp = handle<InstallDownloadableApp>(
-    channel.installDownloadableApp
+    channel.installDownloadableApp,
 );
 
 export const forRenderer = {

ipc/apps.ts

@@ -25,7 +25,7 @@ export const on =
     <T extends (...args: never[]) => void>(channel: string) =>
     (handler: T) =>
         ipcRenderer.on(channel, (_event, ...args: unknown[]) =>
-            handler(...(args as Parameters<T>))
+            handler(...(args as Parameters<T>)),
         );
 
 // Broadcast with a subchannel
@@ -44,10 +44,10 @@ export const broadcast =
 export const onBroadcasted =
     <T extends (...args: never[]) => void>(
         channel: string,
-        subChannel: string
+        subChannel: string,
     ) =>
     (handler: T) =>
         ipcRenderer.on(
             `${channel}_${subChannel}`,
-            (_event, ...args: unknown[]) => handler(...(args as Parameters<T>))
+            (_event, ...args: unknown[]) => handler(...(args as Parameters<T>)),
         );