Merge pull request #1070 from NordicSemiconductor/add_electron_versions

Add electron versions

Author: datenreisender

.github/workflows/test-shared.yml

@@ -16,5 +16,6 @@ jobs:
                   cache: 'npm'
             - run: npm ci
             - run: npm run check
+            - run: npx tsx scripts/check-versions.ts
             - run: npm test
             - run: npm pack

Changelog.md

@@ -7,6 +7,12 @@ This project does _not_ adhere to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
 every new version is a new major version.
 
+## 233.0.0 - 2025-10-10
+
+### Changed
+
+- Use correct Chrome version when building for the renderer process.
+
 ## 232.0.0 - 2025-10-10
 
 ### Changed

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nordicsemiconductor/pc-nrfconnect-shared",
-    "version": "232.0.0",
+    "version": "233.0.0",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",

scripts/check-versions.ts

@@ -0,0 +1,51 @@
+#!/usr/bin/env tsx
+
+/*
+ * Copyright (c) 2025 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
+ */
+
+import { execSync } from 'child_process';
+
+import * as versions from './versions';
+
+const main = async () => {
+    const npmLsElectronResult = execSync('npm ls electron --json', {
+        encoding: 'utf8',
+    });
+    const installedElectronVersion =
+        JSON.parse(npmLsElectronResult).dependencies.electron.version;
+
+    const electronReleases = await (
+        await fetch('https://releases.electronjs.org/releases.json')
+    ).json();
+    const currentElectronRelease = electronReleases.find(
+        (release: { version: string }) =>
+            release.version === installedElectronVersion,
+    );
+
+    if (
+        currentElectronRelease.version !== versions.electron ||
+        currentElectronRelease.chrome !== versions.chrome ||
+        currentElectronRelease.node !== versions.node
+    ) {
+        console.error(
+            `Version mismatch! scripts/versions.ts contains the following versions:
+
+- electron: ${versions.electron}
+- chrome: ${versions.chrome}
+- node: ${versions.node}
+
+but it should contain these:
+
+- electron: ${currentElectronRelease.version}
+- chrome: ${currentElectronRelease.chrome}
+- node: ${currentElectronRelease.node}
+`,
+        );
+        process.exit(1);
+    }
+};
+
+main();

scripts/esbuild-renderer.ts

@@ -14,6 +14,8 @@ import * as module from 'node:module';
 import * as path from 'node:path';
 import tailwindcss from 'tailwindcss';
 
+import { chromeWithoutBuild } from './versions';
+
 const packageJson = JSON.parse(fs.readFileSync('package.json', 'utf8'));
 
 const projectSpecificTailwindConfigPath = path.join(
@@ -42,7 +44,7 @@ const options = (
     ({
         format: 'iife',
         ...outfileOrDir(additionalOptions),
-        target: 'chrome89',
+        target: `chrome${chromeWithoutBuild}`,
         sourcemap: true,
         metafile: false,
         minify: process.argv.includes('--prod'),

scripts/versions.ts

@@ -0,0 +1,11 @@
+/*
+ * Copyright (c) 2025 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
+ */
+
+export const electron = '32.1.2';
+export const chrome = '128.0.6613.162';
+export const node = '20.17.0';
+
+export const chromeWithoutBuild = chrome.replace(/^(\d+\.\d+\.\d+).*$/, '$1');