Skip to content

Commit 379f28f

Browse files
Merge pull request #1047 from NordicSemiconductor/remove_launcher_specific_API
Remove launcher specific API
2 parents a38a782 + 7568f11 commit 379f28f

File tree

5 files changed

+12
-20
lines changed

5 files changed

+12
-20
lines changed

Changelog.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ This project does _not_ adhere to
77
[Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
88
every new version is a new major version.
99

10+
## 223.0.0 - 2025-07-28
11+
12+
### Changed
13+
14+
- Return value of `getDownloadableApps` has less fields now and some more
15+
exports were removed, because they were only needed in the launcher and
16+
having them in shared made changes harder in the launcher.
17+
1018
## 222.0.0 - 2025-07-23
1119

1220
### Added

ipc/apps.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import type {
1111
NrfutilModuleVersion,
1212
UrlString,
1313
} from './MetaFiles';
14-
import { LOCAL, Source, SourceName } from './sources';
14+
import { LOCAL, SourceName } from './sources';
1515

1616
export interface AppSpec {
1717
name: string;
@@ -75,18 +75,11 @@ export type LaunchableApp = LocalApp | InstalledDownloadableApp | WithdrawnApp;
7575

7676
export type App = LocalApp | DownloadableApp;
7777

78-
export interface AppWithError extends AppSpec {
79-
reason: unknown;
80-
path: string;
81-
}
82-
83-
const channel = {
78+
export const channel = {
8479
getDownloadableApps: 'apps:get-downloadable-apps',
8580
installDownloadableApp: 'apps:install-downloadable-app',
8681
};
8782

88-
export type SourceWithError = { source: Source; reason?: string };
89-
9083
export const isDownloadable = (app?: App): app is DownloadableApp =>
9184
app != null && app?.source !== LOCAL;
9285

@@ -115,10 +108,8 @@ export const isUpdatable = (app?: App): app is InstalledDownloadableApp =>
115108
latestVersionHasDifferentChecksum(app));
116109

117110
// getDownloadableApps
118-
type GetDownloadableAppsResult = {
111+
export type GetDownloadableAppsResult = {
119112
apps: DownloadableApp[];
120-
appsWithErrors: AppWithError[];
121-
sourcesWithErrors: SourceWithError[];
122113
};
123114

124115
type GetDownloadableApps = () => GetDownloadableAppsResult;

ipc/sources.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,11 @@
44
* SPDX-License-Identifier: LicenseRef-Nordic-4-Clause
55
*/
66

7-
import { UrlString } from './MetaFiles';
8-
97
enum StandardSourceNames {
108
OFFICIAL = 'official',
119
LOCAL = 'local',
1210
}
1311

1412
export const { LOCAL, OFFICIAL } = StandardSourceNames;
15-
export const allStandardSourceNames: SourceName[] = [OFFICIAL, LOCAL];
1613

1714
export type SourceName = string;
18-
export type SourceUrl = UrlString;
19-
export type Source = { name: SourceName; url: SourceUrl };

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nordicsemiconductor/pc-nrfconnect-shared",
3-
"version": "222.0.0",
3+
"version": "223.0.0",
44
"description": "Shared commodities for developing pc-nrfconnect-* packages",
55
"repository": {
66
"type": "git",

src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,12 +196,10 @@ export {
196196
inMain as apps,
197197
type App as AppType,
198198
type AppSpec,
199-
type AppWithError,
200199
type DownloadableApp,
201200
type InstalledDownloadableApp,
202201
type LaunchableApp,
203202
type LocalApp,
204-
type SourceWithError,
205203
type UninstalledDownloadableApp,
206204
type WithdrawnApp,
207205
} from '../ipc/apps';

0 commit comments

Comments
 (0)