Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noresm2_5_alpha09a: #642

Merged
merged 3 commits into from
Feb 19, 2025
Merged

noresm2_5_alpha09a: #642

merged 3 commits into from
Feb 19, 2025
+48 −6

Conversation

mvdebolskiy
Copy link

@mvdebolskiy mvdebolskiy commented Feb 12, 2025 •
edited by TomasTorsvik
Loading

Summary: BLOM, CAM bug fixes

Contributors: mvdebolskiy,
Reviewers: matsbn, gold2718
Purpose of changes:
Github PR URL:
Changes made to build system: None
Changes made to the namelist: None
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None

Testing: See test results:

Issues addressed by this PR:

  • BLOM: fix for negative salinity values
  • BLOM: remove need for sourcemods when using wave parameterization

@mvdebolskiy mvdebolskiy self-assigned this Feb 12, 2025
@mvdebolskiy mvdebolskiy added this to the NorESM2.5 milestone Feb 12, 2025
@TomasTorsvik TomasTorsvik linked an issue Feb 12, 2025 that may be closed by this pull request
noresm2_5_alpha09a #643
Open
3 tasks
TomasTorsvik
TomasTorsvik reviewed Feb 12, 2025
View reviewed changes
ChangeLog Outdated Show resolved Hide resolved
gold2718
gold2718 previously requested changes Feb 12, 2025
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused. Should there also be an updated .gitmodules files and submodule pointers?

@TomasTorsvik
Copy link
Contributor

I'm confused. Should there also be an updated .gitmodules files and submodule pointers?

@gold2718 - If this is about BLOM, the v1.7.1 tag has not been created yet. I'm waiting for a PR from Mats.

@matsbn
Copy link
Contributor

matsbn commented Feb 12, 2025

I'm confused. Should there also be an updated .gitmodules files and submodule pointers?

@gold2718 - If this is about BLOM, the v1.7.1 tag has not been created yet. I'm waiting for a PR from Mats.

PR NorESMhub/BLOM#485 merged now, @TomasTorsvik.

@TomasTorsvik TomasTorsvik added Enhancement code release Issues related to upcoming code release or tagging and removed Enhancement code release Issues related to upcoming code release or tagging labels Feb 13, 2025
@TomasTorsvik
Copy link
Contributor

@mvdebolskiy , @gold2718 , @matsbn
According to issue #643 , all tasks related to noresm2_5_alpha09a have been completed. Is there anything else holding back the new tag?

@mvdebolskiy
Copy link
Author

@TomasTorsvik
Tests on betzy have been randomly failing at RUN for the last few days.
Also, this tests fail:

  ERI.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERI.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
  ERR_Ld3.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERR_Ld3.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
  ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
    ```
    Is there a fix in blom for the restart of `dustflx0100` by any chance? The failed tests can not have baselines which is not optimal.

@TomasTorsvik
Copy link
Contributor

TomasTorsvik commented Feb 18, 2025 •
edited
Loading

@mvdebolskiy - I'm a bit puzzled why there is a restart dependency on dustflx0100. We don't have a fix for the dustflux at the moment.

I found the same in an earlier test run that I did. No obvious reason why dustflx0100 should behave differently from the other fields. We will look into this.

@mvdebolskiy
Copy link
Author

@TomasTorsvik Testsuite is in /cluster/work/users/mdeb/cicabl, test run directories are in /cluster/work/users/mdeb/noresm
You can reporduce the errors by running ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio test on this pr's branch or by just updating cam to tag noresm2_5_018_cam6_4_041 (to get rid of SFDMS issue).

@TomasTorsvik
Copy link
Contributor

@mvdebolskiy , @jmaerz - looking into this today, and discussing with @jmaerz , we have been able to identify what appears to be a change in a single grid cell for the dustflx0100 filed, but we have not found anything obvious in the code that would explain this behavior for this particular case. I have made a bug issue in BLOM: NorESMhub/BLOM#499

@mvdebolskiy mvdebolskiy marked this pull request as ready for review February 19, 2025 08:38
@mvdebolskiy
Copy link
Author

All tests pass, except for these, due to dustflx0100:

  ERI.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERI.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
  ERR_Ld3.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERR_Ld3.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
  ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio (Overall: FAIL) details:
    FAIL ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio COMPARE_base_rest
    ```
New baselines generated.

@jmaerz
Copy link
Contributor

jmaerz commented Feb 19, 2025

Hi @mvdebolskiy , you wrote that you've observed this for a few days or longer. Is there a time point that this failure started?

TomasTorsvik
TomasTorsvik approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvdebolskiy - thanks, looks fine to me. I'm not sure how long it will take to find and fix the dustflx0100, so I think we can go ahead without this fix for now. It should not affect anything else in NorESM.

@gold2718
Copy link

Is there a time point that this failure started?

These tests passed in noresm2_5_alpha08d:

ERI.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio
ERR_Ld3.ne30pg3_tn14.N1850.betzy_intel.allactive-defaultio

The ERS_D_Ld4.ne30pg3_tn14.N2N1850.betzy_intel.allactive-defaultio is new in alpha09d.

There is a BLOM change between these tags: dev1.6.1.8 ==> v1.7.1. I do not think we have any NorESM2.5 tests with any intermediate version of BLOM.

gold2718
gold2718 approved these changes Feb 19, 2025
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay from my end

@mvdebolskiy mvdebolskiy merged commit c99dca6 into NorESMhub:noresm_develop Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 approved these changes

@TomasTorsvik TomasTorsvik TomasTorsvik approved these changes

@matsbn matsbn Awaiting requested review from matsbn

Assignees

@mvdebolskiy mvdebolskiy

Labels
None yet
Projects
NorESM Development
Status: Done
Milestone
NorESM2.5
Development

Successfully merging this pull request may close these issues.

noresm2_5_alpha09a
5 participants
@mvdebolskiy @TomasTorsvik @matsbn @jmaerz @gold2718