issue with v1

[prmoore77]

Hi, I use the docker-manifest-action - and it has been working fine with version: 0.4.3 - in my pipeline here:
https://github.com/gizmodata/gizmosql/blob/4cea4544efc0681b796623e49ee58bba2e3ceda4/.github/workflows/build-docker-images.yml#L214

When I attempted to use 1.0.0, however - I am experiencing failure of the pipeline. Here is an excerpt of the failure from the log:

$ docker buildx imagetools create gizmodata/gizmosql:latest gizmodata/gizmosql:v1.9.9 --tag=gizmodata/gizmosql:latest-amd64 --tag=gizmodata/gizmosql:latest-arm64
  /usr/bin/docker buildx imagetools create gizmodata/gizmosql:latest gizmodata/gizmosql:v1.9.9 --tag=gizmodata/gizmosql:latest-amd64 --tag=gizmodata/gizmosql:latest-arm64
  ERROR: docker.io/gizmodata/gizmosql:v1.9.9: not found
  file:///home/runner/work/_actions/Noelware/docker-manifest-action/v1/build/index.js:58

Here is the output from a previous run which was on 0.4.3:

Creating manifest for image [gizmodata/gizmosql:latest] with [gizmodata/gizmosql:latest-amd64, gizmodata/gizmosql:latest-arm64] outputs
Creating manifest for image [gizmodata/gizmosql:v1.9.4] with [gizmodata/gizmosql:latest-amd64, gizmodata/gizmosql:latest-arm64] outputs
/usr/bin/docker manifest create gizmodata/gizmosql:latest gizmodata/gizmosql:latest-amd64 gizmodata/gizmosql:latest-arm64
/usr/bin/docker manifest create gizmodata/gizmosql:v1.9.4 gizmodata/gizmosql:latest-amd64 gizmodata/gizmosql:latest-arm64
Created manifest list docker.io/gizmodata/gizmosql:latest
Took 2248.0s to create manifest for image [gizmodata/gizmosql:latest] with [gizmodata/gizmosql:latest-amd64, gizmodata/gizmosql:latest-arm64] as the outputs!
Now pushing image gizmodata/gizmosql:latest
/usr/bin/docker manifest push gizmodata/gizmosql:latest
Created manifest list docker.io/gizmodata/gizmosql:v1.9.4
Took 2283.0s to create manifest for image [gizmodata/gizmosql:v1.9.4] with [gizmodata/gizmosql:latest-amd64, gizmodata/gizmosql:latest-arm64] as the outputs!
Now pushing image gizmodata/gizmosql:v1.9.4

Did I do this wrong, or does this represent a bug with 1.0.0 of the Github Action? Thank you...

[auguwu]

I think it's more with the inputs. In v1, images were changed to tags to better reflect the imagetools frontend that the action uses and inputs remain the same.

Though, this is probably at fault of me since I didn't properly discuss it in the README since I made updates to it before I edited the inputs to be better reflected, so I am deeply sorry about that.

If I can recall correctly, you can just switch images to tags and it should work. If not, you can just reach out and I can try to fix it on our end.

Thanks for using our action though! <3
I'll keep this issue open for now.

[prmoore77]

Hey @auguwu - thanks for the quick response. I did change images to tags - here was the failing code:

      - name: Create and push slim manifest images - Github
        uses: Noelware/docker-manifest-action@v1
        with:
          inputs: ${{ env.GITHUB_IMAGE_NAME }}:latest-slim,${{ env.GITHUB_IMAGE_NAME }}:${{ github.ref_name }}-slim
          tags: ${{ env.GITHUB_IMAGE_NAME }}:latest-amd64-slim,${{ env.GITHUB_IMAGE_NAME }}:latest-arm64-slim
          push: true

It seems that the Action used to issue 2 commands (docker manifest create) - one per tag, now it is generating 1 command (docker buildx imagetools create gizmodata/gizmosql:latest gizmodata/gizmosql:v1.9.9 ) - for both tags...

[auguwu]

Weird, it shouldn't even be using docker buildx imagetools if it's going to fallback to docker manifest. Can you run it in debug mode and give the full output?

[prmoore77]

hi @auguwu - I'll try to do this soon - I've been swamped, sorry...

[auguwu]

No worries! I get everyone is busy and all. :)

[carry0987]

I encountered the same issue. The new imagetools feature in v1 cannot directly merge images built separately before into a multi-platform image, like the previous manifest command could.

Because of the benefits of imagetools mentioned in this article—including support for provenance and more modern image handling—I would prefer to use imagetools rather than the traditional manifest.

Here is my build-image.yml file

name: Build and Push Docker Image to GHCR.io

on:
  push:
    tags:
      - 'v*'

jobs:
  build-and-push:
    runs-on: ${{ matrix.os }}
    permissions:
      contents: read
      packages: write
    strategy:
      fail-fast: false
      matrix:
        include:
          - os: ubuntu-latest
            platform: linux/amd64
          - os: namespace-profile-default-arm64
            platform: linux/arm64
    outputs:
      version: ${{ env.version }}
    steps:
      - name: Check out the repo
        uses: actions/checkout@v5

      - name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v3

      - name: Login to GHCR.io
        uses: docker/login-action@v3
        with:
          registry: ghcr.io
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Prepare the Docker tags list
        id: prep
        run: |
          FULL_VERSION=$(echo ${{ github.ref }} | sed -e 's,.*/v,,')
          VERSION=${FULL_VERSION}
          TAGS="ghcr.io/${{ github.actor }}/test-docker-image:${VERSION}"
          if [[ ${{ matrix.platform }} == "linux/amd64" ]]; then
            SUFFIX="-amd64"
          elif [[ ${{ matrix.platform }} == "linux/arm64" ]]; then
            SUFFIX="-arm64"
          fi
          TAGS="ghcr.io/${{ github.actor }}/test-docker-image:${VERSION}${SUFFIX}"
          echo "TAGS=$TAGS" >> $GITHUB_ENV
          echo "PROGRAM_VERSION=${VERSION%}" >> $GITHUB_ENV
          echo "version=${VERSION%}" >> $GITHUB_ENV
          echo "PROGRAM_VERSION=${VERSION%}"
          echo "Building with tags: $TAGS"

      - name: Start multi-arch build and push
        uses: docker/build-push-action@v6
        with:
          file: Dockerfile
          build-args: PROGRAM_VERSION=${{ env.PROGRAM_VERSION }}
          push: true
          tags: ${{ env.TAGS }}
          platforms: ${{ matrix.platform }}
          provenance: false

      - name: Logout from GHCR.io
        run: docker logout ghcr.io

  manifest:
    needs: build-and-push
    runs-on: ubuntu-latest
    permissions:
      contents: read
      packages: write
    steps:
      - name: Check out the repo
        uses: actions/checkout@v5

      - name: Login to GHCR.io
        uses: docker/login-action@v3
        with:
          registry: ghcr.io
          username: ${{ github.actor }}
          password: ${{ secrets.GITHUB_TOKEN }}

      - name: Set image prefix
        run: echo "IMAGE_PREFIX=ghcr.io/${{ github.actor }}/test-docker-image:${{ needs.build-and-push.outputs.version }}" >> $GITHUB_ENV

      - name: Create and push manifest images
        uses: Noelware/docker-manifest-action@master
        with:
          fallback: false
          inputs: ghcr.io/${{ github.actor }}/test-docker-image:${{ needs.build-and-push.outputs.version }}
          tags: ${{ env.IMAGE_PREFIX }}-amd64,${{ env.IMAGE_PREFIX }}-arm64
          push: true
          append: true
          annotations: |
            org.opencontainers.image.description="A test Docker image for multi-arch builds (VERSION)"

      - name: Logout from GHCR.io
        run: docker logout ghcr.io

[auguwu]

Sorry for the late comment, I've been dealing with a lot of IRL issues going on right now! I'll try my best to investigate this with the new context :)

[carry0987]

Sorry for the late comment, I've been dealing with a lot of IRL issues going on right now! I'll try my best to investigate this with the new context :)

Thanks a lot!

[auguwu]

I am making a re-production of this issue via the noel/fix-issue-880 branch. I have a feeling that inputs and tags are being mixed up (probably because I am not the best at writing documentation at all) but we'll see.

[auguwu]

I'm not sure on what is going on, which repository is this happening on so I can take a look (if it's public) but for what I tried, it seems to work each time for me?

[carry0987]

I'm not sure on what is going on, which repository is this happening on so I can take a look (if it's public) but for what I tried, it seems to work each time for me?

Here is the testing repo for this example: LINK

[auguwu]

I'm not sure on what is going on, which repository is this happening on so I can take a look (if it's public) but for what I tried, it seems to work each time for me?

Here is the testing repo for this example: LINK

From the docs of docker buildx imagetools create it does specify this:

If only one source is specified and that source is a manifest list or image index, create performs a carbon copy. If one source is specified and that source is not a list or index, the output will be a manifest list, however you can disable this behavior with --prefer-index=false which attempts to preserve the source manifest format in the output.

If you're able to switch inputs -> tags and tags -> inputs, it should work but if it doesn't, I'll add a prefer-index action input and see if that works.

Edit #1: I have a feeling that inputs is no longer a valid key to be used, maybe we could change it to sources (like it does in the Docker docs) and deprecate inputs?