Fix parser not working with huge buffers (e.g. 300mb)

Closes #8

Author: Ruben Bridgewater

changelog.md

@@ -1,3 +1,9 @@
+## v.2.0.3 - 17 Jun, 2016
+
+Bugfixes
+
+-  Fixed parser not working with huge buffers (e.g. 300 MB)
+
 ## v.2.0.2 - 08 Jun, 2016
 
 Bugfixes

lib/parser.js

@@ -313,7 +313,7 @@ function decreaseBufferPool () {
     // Balance between increasing and decreasing the bufferPool
     if (counter === 1 || notDecreased > counter * 2) {
       // Decrease the bufferPool by 16kb by removing the first 16kb of the current pool
-      bufferPool = bufferPool.slice(16 * 1024, bufferPool.length)
+      bufferPool = bufferPool.slice(Math.floor(bufferPool.length / 10), bufferPool.length)
     } else {
       notDecreased++
       counter--
@@ -338,12 +338,17 @@ function concatBuffer (parser, length) {
   length -= parser.offset
   if (bufferPool.length < length + bufferOffset) {
     // Increase the bufferPool size by three times the current needed length
-    bufferPool = new Buffer(length * 3 + bufferOffset)
+    var multiplier = 3
+    if (bufferOffset > 1024 * 1024 * 200) {
+      bufferOffset = 1024 * 1024 * 50
+      multiplier = 2
+    }
+    bufferPool = new Buffer(length * multiplier + bufferOffset)
     bufferOffset = 0
     counter++
     pos = 0
     if (interval === null) {
-      interval = setInterval(decreaseBufferPool, 30)
+      interval = setInterval(decreaseBufferPool, 50)
     }
   }
   list[0].copy(bufferPool, pos, parser.offset, list[0].length)
@@ -369,10 +374,10 @@ JavascriptRedisParser.prototype.execute = function (buffer) {
   } else if (this.bigStrSize === 0) {
     var oldLength = this.buffer.length
     var remainingLength = oldLength - this.offset
-    var bufferPool = new Buffer(remainingLength + buffer.length)
-    this.buffer.copy(bufferPool, 0, this.offset, oldLength)
-    buffer.copy(bufferPool, remainingLength, 0, buffer.length)
-    this.buffer = bufferPool
+    var newBuffer = new Buffer(remainingLength + buffer.length)
+    this.buffer.copy(newBuffer, 0, this.offset, oldLength)
+    buffer.copy(newBuffer, remainingLength, 0, buffer.length)
+    this.buffer = newBuffer
     this.offset = 0
   } else if (this.totalChunkSize + buffer.length >= this.bigStrSize) {
     this.bufferCache.push(buffer)

package.json

@@ -35,7 +35,7 @@
     "istanbul": "^0.4.0",
     "standard": "^7.0.1",
     "mocha": "^2.3.2",
-    "hiredis": "^0.4.1"
+    "hiredis": "^0.5.0"
   },
   "author": "Ruben Bridgewater",
   "license": "MIT",