Fixed Buff Logic

* Added buff handler, so we don't end up with a permanent BM bonuses.

Author: SalmanTKhan

src/ZoneServer/Buffs/Handlers/Common/RidingCompanion.cs

@@ -0,0 +1,38 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+using Melia.Shared.Game.Const;
+using Melia.Zone.Buffs.Base;
+using Melia.Zone.World.Actors.Characters;
+using Melia.Zone.World.Actors.CombatEntities.Components;
+
+namespace Melia.Zone.Buffs.Handlers.Common
+{
+	/// <summary>
+	/// Handle for the Riding Companion Buff, which gives certain bonuses.
+	/// </summary>
+	public class RidingCompanion : BuffHandler
+	{
+		public override void OnStart(Buff buff)
+		{
+			var target = (Character)buff.Target;
+
+			// Generic values from Velheider, should be companion specific?
+			target.Properties.Modify(PropertyName.MSPD_BM, 4f);
+			target.Properties.Modify(PropertyName.DR_BM, 3f);
+			target.Properties.Modify(PropertyName.DEF_BM, 12f);
+		}
+
+		public override void OnEnd(Buff buff)
+		{
+			var target = (Character)buff.Target;
+
+			// Generic values from Velheider, should be companion specific?
+			target.Properties.Modify(PropertyName.MSPD_BM, -4f);
+			target.Properties.Modify(PropertyName.DR_BM, -3f);
+			target.Properties.Modify(PropertyName.DEF_BM, -12f);
+		}
+	}
+}

src/ZoneServer/Network/PacketHandler.cs

@@ -3022,10 +3022,7 @@ public void CZ_VEHICLE_RIDE(IZoneConnection conn, Packet packet)
 				{
 					character.StartBuff(BuffId.RidingCompanion, 0, 0, TimeSpan.Zero, companion);
 					companion.StartBuff(BuffId.TakingOwner, 0, 0, TimeSpan.Zero, character);
-					// This is buff logic
-					character.Properties.Modify(PropertyName.MSPD_BM, 4f);
-					character.Properties.Modify(PropertyName.DR_BM, 3f);
-					character.Properties.Modify(PropertyName.DEF_BM, 12f);
+
 					Send.ZC_OBJECT_PROPERTY(character, PropertyName.MSPD, PropertyName.MSPD_BM,
 						PropertyName.DR, PropertyName.DR_BM, PropertyName.MHP, PropertyName.MHP_RATE_BM,
 						PropertyName.DEF, PropertyName.DEF_BM);
@@ -3035,9 +3032,7 @@ public void CZ_VEHICLE_RIDE(IZoneConnection conn, Packet packet)
 				{
 					character.StopBuff(BuffId.RidingCompanion);
 					companion.StopBuff(BuffId.TakingOwner);
-					character.Properties.Modify(PropertyName.MSPD_BM, -4f);
-					character.Properties.Modify(PropertyName.DR_BM, -3f);
-					character.Properties.Modify(PropertyName.DEF_BM, -12f);
+
 					Send.ZC_OBJECT_PROPERTY(character, PropertyName.MSPD, PropertyName.MSPD_BM,
 						PropertyName.DR, PropertyName.DR_BM, PropertyName.MHP, PropertyName.MHP_RATE_BM,
 						PropertyName.DEF, PropertyName.DEF_BM);