Expose vsync setting (#62)

* Add vsync setting

* Remove vsync command

Author: jfaz1

docs/settings.gen.md

@@ -123,6 +123,7 @@ For examples and default values see [here](../config/settings.json)
 | `ui.tab-header-width` | int | 30 | Width of tab layout headers in characters |
 | `ui.theme` | string | "app://themes/tokyo-night-color-theme.json" | VFS path of the theme. |
 | `ui.toast-duration` | int | 8000 | How long toasts are displayed for, in milliseconds. |
+| `ui.vsync` | bool | true | Enable vertical sync to prevent screen tearing. |
 | `ui.which-key-delay` | int | 250 | After how many milliseconds the which key window opens. |
 | `ui.which-key-height` | int | 6 | How many rows tall the window showing next possible inputs should be. |
 | `ui.which-key-no-progress` | bool | false | If true then the window showing next possible inputs will be displayed even when no keybinding is in progress (i.e. it will always be shown). |

scripting/editor_api_wasm.nim

@@ -292,14 +292,6 @@ proc loadTheme*(name: string; force: bool = false) {.gcsafe, raises: [].} =
       argsJsonString.cstring)
 
 
-proc editor_vsync_void_App_bool_wasm(arg: cstring): cstring {.importc.}
-proc vsync*(enabled: bool) {.gcsafe, raises: [].} =
-  var argsJson = newJArray()
-  argsJson.add enabled.toJson()
-  let argsJsonString = $argsJson
-  let res {.used.} = editor_vsync_void_App_bool_wasm(argsJsonString.cstring)
-
-
 proc editor_openSession_void_App_string_bool_float_float_float_wasm(arg: cstring): cstring {.
     importc.}
 proc openSession*(root: string = "home://"; preview: bool = true;

src/app.nim

@@ -765,18 +765,18 @@ proc applySettingsFromAppOptions(self: App) =
 
 proc applyFontSettings(self: App) =
   let fontRegular = self.uiSettings.fontFamily.get
-  let fontBold = self.uiSettings.fontFamilyBold.get  
+  let fontBold = self.uiSettings.fontFamilyBold.get
   let fontItalic = self.uiSettings.fontFamilyItalic.get
   let fontBoldItalic = self.uiSettings.fontFamilyBoldItalic.get
-  
+
   if fontRegular != self.fontRegular or
      fontBold != self.fontBold or
      fontItalic != self.fontItalic or
      fontBoldItalic != self.fontBoldItalic:
     log lvlInfo, &"Applying font settings: {fontRegular}, {fontBold}, {fontItalic}, {fontBoldItalic}"
     self.fontRegular = fontRegular
     self.fontBold = fontBold
-    self.fontItalic = fontItalic  
+    self.fontItalic = fontItalic
     self.fontBoldItalic = fontBoldItalic
     self.platform.setFont(self.fontRegular, self.fontBold, self.fontItalic, self.fontBoldItalic, self.fallbackFonts)
 
@@ -874,6 +874,8 @@ proc newApp*(backend: api.Backend, platform: Platform, services: Services, optio
   self.uiSettings = UiSettings.new(self.config.runtime)
   self.generalSettings = GeneralSettings.new(self.config.runtime)
 
+  self.platform.setVsync(self.uiSettings.vsync.get)
+
   self.applyFontSettings()
 
   self.themes.setTheme(defaultTheme())
@@ -954,6 +956,8 @@ proc newApp*(backend: api.Backend, platform: Platform, services: Services, optio
       self.reloadThemeFromConfig = true
     if key == "" or key == "ui" or key.startsWith("ui.font-family"):
       self.applyFontSettings()
+    if key == "" or key == "ui" or key == "ui.vsync":
+      self.platform.setVsync(self.uiSettings.vsync.get)
 
   if not options.dontRestoreConfig:
     if options.sessionOverride.getSome(session):
@@ -1409,9 +1413,6 @@ proc loadWorkspaceFile*(self: App, path: string) =
 proc loadTheme*(self: App, name: string, force: bool = false) {.expose("editor").} =
   asyncSpawn self.setTheme(fmt"app://themes/{name}.json", force)
 
-proc vsync*(self: App, enabled: bool) {.expose("editor").} =
-  self.platform.setVsync(enabled)
-
 proc loadSessionAsync(self: App, session: string, close: bool) {.async.} =
   try:
     let path = self.vfs.localize(session)

src/config_provider.nim

@@ -1060,6 +1060,9 @@ declareSettings UiSettings, "ui":
   ## How long the cursor trail is. Set to 0 to disable cursor trail.
   declare cursorTrailLength, int, 2
 
+  ## Enable vertical sync to prevent screen tearing.
+  declare vsync, bool, true
+
   ## How line numbers should be displayed.
   declare lineNumbers, LineNumbers, LineNumbers.Absolute